Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression (v4.2.1): AnimationTree: animation_started signal is always emitted twice #91532

Open
hsandt opened this issue May 3, 2024 · 3 comments

Comments

@hsandt
Copy link
Contributor

hsandt commented May 3, 2024

Tested versions

  • Reproducible in v4.2.beta4.official [93cdacb], v4.2.1.stable.official [b09f793]

System information

Godot v4.2.1.stable - Ubuntu 22.04.4 LTS 22.04 - X11 - Vulkan (Mobile) - dedicated NVIDIA GeForce GTX 860M (nvidia; 535.161.07) - Intel(R) Core(TM) i7-4710HQ CPU @ 2.50GHz (8 Threads)

Issue description

This is a reboot of #80118 which was supposedly fixed in v4.2, but I experienced the issue in v4.2.1. Even v4.2.beta4 has the bug, so I'm not sure the fix really worked - or it worked for a very specific version only.

Steps to reproduce

  1. Download the MWE from AnimationTree: animation_started signal is always emitted twice #80118 (just upgrade it to v4.2)
  2. Run the scene
  3. Press Space / Enter to trigger ui_accept and see the 2x animated started + 1x animation finished message

Minimal reproduction project (MRP)

Same as #80118

Here is a direct link for convenience: https://github.com/godotengine/godot/files/12229864/anim_tree_signal_bug.zip

@hsandt
Copy link
Contributor Author

hsandt commented May 3, 2024

I wonder if the double signal emission is related to switching to RESET animation as an intermediate state... One could try to remove the RESET animation, see if it has any impact.

@TokageItLab
Copy link
Member

Can't reproduce in master (4.3.dev6)

@hsandt
Copy link
Contributor Author

hsandt commented May 5, 2024

OK, will build master and try again today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants