-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Notation docs in sign-images.md #541
Conversation
…sign or Notation to demonstrate how to configure HTTPS domain for secure image signing and verification using the Notation CLI Signed-off-by: Roseline <roselynbassey23@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Roseline-Bassey . See my comments above
Signed-off-by: Roseline <roselynbassey23@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Hi @Roseline-Bassey , Appreciate your contribution to harbor community! Best, |
Hi @wy65701436 @MinerYang , The changes of this PR seem not reflect on the Harbor website: https://goharbor.io/docs/2.10.0/working-with-projects/working-with-images/sign-images/#use-notationexperimental-to-sign-artifacts-with-distribution-spec-v11-mode. Is this normal? |
@FeynmanZhou it needs to be cherry picked to 2.10 |
@OrlinVasilev |
This PR includes an update to the existing Notation docs section in "Sign Artifacts with Cosign or Notation".
The update demonstrates how to configure an HTTPS domain for secure image signing and verification with the Notation CLI.
It fixes #540