New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MySQL storage should not return SQL-specific errors #2341

Open

pav-kv opened this issue Feb 8, 2021 · 1 comment

Labels

bug

Contributor

pav-kv commented Feb 8, 2021 •

edited

The are conditions under which SQL-specific errors slip all the way to the client.

Example of what this can cause: #2340, reproduced in #2342.

We should either allow this in storage APIs, or fix MySQL implementation to wrap these errors into "generic" ones.

pav-kv self-assigned this

pav-kv mentioned this issue

Reproduce issue 2341 #2342

Closed

Contributor Author

pav-kv commented Feb 8, 2021

Go's database/sql can return inconsistent errors on context cancelation: https://go.googlesource.com/go/+/go1.15.8/src/database/sql/sql.go#2144

pav-kv removed their assignment

mhutchinson added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment