Fix Chatbot, Dataframe, Markdown custom components #8339
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/0c71c4fb4ed31e931df863aa9885936012461b79/gradio-4.31.4-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@0c71c4fb4ed31e931df863aa9885936012461b79#subdirectory=client/python" |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
|
Do you think it would make sense to add a test to ensure all of our core components can be used as templates for custom components? |
|
I think to test this we would have to run dev or build after generating them and this process is quite slow, so this would add a substantial amount of time to CI. Open to any suggestions to speed it up though, it would be nice to have some kind of check. |
|
Yes a CI test would make sense. I tried to add one in #6715 but it would not work in CI. @pngwn is right though that it would be really slow to test all core components. Maybe we can create a giant custom component directory and launch a kitchen sink style demo. @pngwn let me know if this particular change looks good though. |
|
Thank you @pngwn 🙏 |
Description
Closes: #8309
You can verify this works by templating off of DataFrame or Chatbot and making the following modifications to
@gradio/markdownin node_modules.🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.shYou may need to run the linters:
bash scripts/format_backend.shandbash scripts/format_frontend.sh