Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hasura auth webhook spankind of SERVER #10241

Open
manasag opened this issue May 15, 2024 · 1 comment
Open

Hasura auth webhook spankind of SERVER #10241

manasag opened this issue May 15, 2024 · 1 comment
Labels
k/enhancement New feature or improve an existing feature observability v2

Comments

@manasag
Copy link
Contributor

manasag commented May 15, 2024

The first call to the webhook, POST/authenticate, has a SpanKind of INTERNAL:

Since it is the first call in a service that appears to be a synchronous request-response flow, the SpanKind should be SERVER. (OTel docs for reference -- SpanKind)
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/api.md#spankind

Request is, when Hasura emits spans for this particular call, can it have a SpanKind of SERVER please?

@manasag manasag added k/enhancement New feature or improve an existing feature observability v2 labels May 15, 2024
@obs-gh-rakeshgupta
Copy link

👋 Wanted to add some color to this one -- we have customers using Hasura, they love the fact that Hasura emits OTel span data, and they want to use that data to visualize the full request flow in our service map & trace view including the calls out to Hasura services. Currently the Hasura auth webhook service won't show in the service map since we follow the spec and assume that the first span in a service call is not of kind INTERNAL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
k/enhancement New feature or improve an existing feature observability v2
Projects
None yet
Development

No branches or pull requests

2 participants