Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make retryingRoundTripper type public #13052

Open
Valgueiro opened this issue May 21, 2024 · 1 comment
Open

Make retryingRoundTripper type public #13052

Valgueiro opened this issue May 21, 2024 · 1 comment

Comments

@Valgueiro
Copy link

Valgueiro commented May 21, 2024 •
edited

Hello team,

My team encountered an issue in Fluxcd (fluxcd/flux2#4804) that seems to be related to an issue that was already solved here (#11426). When trying to replicate the solution there, I saw on the code that the retryingRoundTripper is private to the helm cli package (https://github.com/helm/helm/blob/main/pkg/cli/roundtripper.go#L27).

Can we make it public? Do you guys see any issues on doing this?
@jnummelin
Copy link

plus one on this one

We also use Helm as library in our project and having to "inline" the retryingRoundTripper would be unwanted.

@twz123 twz123 mentioned this issue May 29, 2024
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jnummelin @Valgueiro