-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move MarigoldPipeline to core #7522
Comments
@markkua and I would like to help shape the way Marigold is integrated. We need to discuss this internally and with you to plan this design carefully and enable the pipeline's extensibility to other modalities (which are brewing). In the meantime, can @yiyixuxu please point us to a PR for a community pipeline promotion to the core so we can use it as a reference? Particularly, I'm curious to see how core philosophy is maintained (1) to balance modularity vs ensuring the quality of operation in a default setting and (2) automated test suite, if any |
A PR #7524 to the community pipeline is just created for some small updates. Please also take this update into consideration. |
hey @toshas and @markkua we don't have an example of community pipeline -> official pipeline that's already merged and can serve as a good reference. Marigold has the chance to become the first to come from the community! two other community pipelines are being moved to official pipelines, feel free to take a look at the PRs; they are both more challenging than MarigoldPipeline: face-id requires a different design when integrated into core; and ControlNet-XS, the original implementation deviates a lot from our style so a lot of works need to be done to refactor it |
do we have a channel with you on slack? |
Yes, |
Model/Pipeline/Scheduler description
Marigold depth pipeline is one of our most highly used community pipeline (it already has 40k downloads on the hub) - we are going to integrate it into core upon popular demand
Does anyone in the community like to take a stab at this? It is already a community pipeline, so we do not need to convert weights. however, we may need to refactor it so that the implementation follows the diffusers' design philosophy and that the codes are highly readable and easy to tweak. You can read about philosophy here https://huggingface.co/docs/diffusers/en/conceptual/philosophy
Of course, it will be an iterative process! You can start the PR by moving the pipeline code into a folder under
src,
and tagging diffusers maintainers for an initial reviewProvide useful links for the implementation
community pipeline: https://github.com/huggingface/diffusers/blob/main/examples/community/marigold_depth_estimation.py)
original issue: #6533
The text was updated successfully, but these errors were encountered: