Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] help us speed up the fast pipeline tests #7677

Open
sayakpaul opened this issue Apr 15, 2024 · 6 comments · May be fixed by #7865 or #7898
Open

[Tests] help us speed up the fast pipeline tests #7677

sayakpaul opened this issue Apr 15, 2024 · 6 comments · May be fixed by #7865 or #7898

Comments

@sayakpaul
Copy link
Member

sayakpaul commented Apr 15, 2024

Currently, the pipeline tests (located under tests/pipelines) take a bit of time to run. We recently performed some optimizations to speed them up but, we can do better.

This is especially desirable because it greatly improves the contribution experience not just for the community but also for us, maintainers. So, we welcome contributions from the community to improve the pipeline test suite that runs during PRs 🤗

What's the problem?

Many pipeline tests (here's an example) use model-level components (such as the UNet) whose size can be made much smaller for testing purposes. The bigger their size, the longer it's going to take to execute them (obviously).

How can you help?

Reduce the sizes of the model-level components and thereby making the pipeline tests run faster.

How should you submit a PR?

  • Start by inspecting the get_dummy_components() function (example) for a given pipeline test script.
  • If you think that the block sizes could further be reduced, make changes, and then run the testing suite.
  • Submit a PR with your changes.

Things to note

  • When submitting a PR, please consider one and only PR pipeline test script at a time.
  • Please tag me in your PR descriptions and mention this issue so that we can keep a proper track.
  • You should try to keep the scope of the changes ONLY to the get_dummy_components() function. If further changes are required, please explain the motivation behind them in your PR description.
  • You can refer to [Tests] reduce the model sizes in the SD fast tests #7580 as a reference.

@yiyixuxu @DN6 for awareness and visibility.

@ihkap11
Copy link
Contributor

ihkap11 commented Apr 16, 2024

Hey @sayakpaul I'd like to take a shot at this. :)

@sayakpaul
Copy link
Member Author

Feel free to target one pipeline test and send over a PR :)

@chiral-carbon
Copy link
Contributor

Hi @sayakpaul, I would like to contribute!

@sayakpaul
Copy link
Member Author

Feel free to target one pipeline test and send over a PR :)

@AbhinavJangra29
Copy link

hey @sayakpaul i am interested to work on this!

@sayakpaul
Copy link
Member Author

@AbhinavJangra29 feel free to open a PR and tag me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants