{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":570384908,"defaultBranch":"main","name":"peft","ownerLogin":"huggingface","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2022-11-25T03:51:09.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/25720743?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1717771093.0","currentOid":""},"activityList":{"items":[{"before":"a136acedf1c2cdef8fddd6be7b48f171045846fc","after":null,"ref":"refs/heads/younesbelkada-add-bnb-notif-import","pushedAt":"2024-06-07T14:38:13.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"younesbelkada","name":"Younes Belkada","path":"/younesbelkada","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/49240599?s=80&v=4"}},{"before":"03798a9143c90d796a0bee8f43863668d084381f","after":"0b40d1a304fc4d7d10baef14f913baff533dc2dc","ref":"refs/heads/main","pushedAt":"2024-06-07T14:38:10.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"younesbelkada","name":"Younes Belkada","path":"/younesbelkada","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/49240599?s=80&v=4"},"commit":{"message":"Workflow / Bnb: Add a mechanism to inform us if the import fails (#1830)\n\n* Update nightly-bnb.yml\r\n\r\n* Update nightly-bnb.yml\r\n\r\n* Update .github/workflows/nightly-bnb.yml\r\n\r\n* Update .github/workflows/nightly-bnb.yml","shortMessageHtmlLink":"Workflow / Bnb: Add a mechanism to inform us if the import fails (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2335964285\" data-permission-text=\"Title is private\" data-url=\"https://github.com/huggingface/peft/issues/1830\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/huggingface/peft/pull/1830/hovercard\" href=\"https://github.com/huggingface/peft/pull/1830\">#1830</a>)"}},{"before":"8e054d525d18f033f3f8d90cbcfd1e36a3f4ae0b","after":"a136acedf1c2cdef8fddd6be7b48f171045846fc","ref":"refs/heads/younesbelkada-add-bnb-notif-import","pushedAt":"2024-06-07T09:55:24.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"younesbelkada","name":"Younes Belkada","path":"/younesbelkada","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/49240599?s=80&v=4"},"commit":{"message":"Update .github/workflows/nightly-bnb.yml","shortMessageHtmlLink":"Update .github/workflows/nightly-bnb.yml"}},{"before":"3c416362fe9ea4b39d873f1f8d8c24a30bc18f9b","after":"8e054d525d18f033f3f8d90cbcfd1e36a3f4ae0b","ref":"refs/heads/younesbelkada-add-bnb-notif-import","pushedAt":"2024-06-07T09:27:53.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"younesbelkada","name":"Younes Belkada","path":"/younesbelkada","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/49240599?s=80&v=4"},"commit":{"message":"Update .github/workflows/nightly-bnb.yml","shortMessageHtmlLink":"Update .github/workflows/nightly-bnb.yml"}},{"before":"d33c1f118e8266a94388c779968ddf9d2cbe2218","after":"03798a9143c90d796a0bee8f43863668d084381f","ref":"refs/heads/main","pushedAt":"2024-06-06T13:49:59.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"BenjaminBossan","name":"Benjamin Bossan","path":"/BenjaminBossan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6229650?s=80&v=4"},"commit":{"message":"FIX Failing Llama tests due to new kv cache (#1832)\n\nThe issue is that past_key_values can now be an instance of\r\nDynamicCache. Therefore, just indexing into it won't work anymore. The\r\nsolution is to check the type and if it's not a tuple/list, use the methods\r\non the cache object instead.","shortMessageHtmlLink":"FIX Failing Llama tests due to new kv cache (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2337756955\" data-permission-text=\"Title is private\" data-url=\"https://github.com/huggingface/peft/issues/1832\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/huggingface/peft/pull/1832/hovercard\" href=\"https://github.com/huggingface/peft/pull/1832\">#1832</a>)"}},{"before":"63a536b18e1d0ea4094c946a04807f1340627372","after":"d33c1f118e8266a94388c779968ddf9d2cbe2218","ref":"refs/heads/main","pushedAt":"2024-06-06T13:34:10.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"younesbelkada","name":"Younes Belkada","path":"/younesbelkada","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/49240599?s=80&v=4"},"commit":{"message":"fix doc typo (#1833)","shortMessageHtmlLink":"fix doc typo (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2338009555\" data-permission-text=\"Title is private\" data-url=\"https://github.com/huggingface/peft/issues/1833\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/huggingface/peft/pull/1833/hovercard\" href=\"https://github.com/huggingface/peft/pull/1833\">#1833</a>)"}},{"before":"91d5e8c271a0c6c524c5d373f974b2c91d838e23","after":"3c416362fe9ea4b39d873f1f8d8c24a30bc18f9b","ref":"refs/heads/younesbelkada-add-bnb-notif-import","pushedAt":"2024-06-06T08:49:24.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"younesbelkada","name":"Younes Belkada","path":"/younesbelkada","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/49240599?s=80&v=4"},"commit":{"message":"Update nightly-bnb.yml","shortMessageHtmlLink":"Update nightly-bnb.yml"}},{"before":"ad8f7cb59ee7ca4b9ca1c9048711038ac36b31b8","after":"63a536b18e1d0ea4094c946a04807f1340627372","ref":"refs/heads/main","pushedAt":"2024-06-06T08:44:03.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"BenjaminBossan","name":"Benjamin Bossan","path":"/BenjaminBossan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6229650?s=80&v=4"},"commit":{"message":"TST Make tests pass on Cambricon MLUs  (#1747)\n\nSmall adjustments to tests to make them pass on Cambricon MLUs (mostly\r\ntolerances). Note that we have no MLU test runners for PEFT, so have to\r\nrely on others to run these tests.","shortMessageHtmlLink":"TST Make tests pass on Cambricon MLUs (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2305228373\" data-permission-text=\"Title is private\" data-url=\"https://github.com/huggingface/peft/issues/1747\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/huggingface/peft/pull/1747/hovercard\" href=\"https://github.com/huggingface/peft/pull/1747\">#1747</a>)"}},{"before":null,"after":"91d5e8c271a0c6c524c5d373f974b2c91d838e23","ref":"refs/heads/younesbelkada-add-bnb-notif-import","pushedAt":"2024-06-05T13:44:23.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"younesbelkada","name":"Younes Belkada","path":"/younesbelkada","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/49240599?s=80&v=4"},"commit":{"message":"Update nightly-bnb.yml","shortMessageHtmlLink":"Update nightly-bnb.yml"}},{"before":"ca1f135e7e874feac57868be5131a5a82b8ad7eb","after":null,"ref":"refs/heads/younesbelkada-patch-3","pushedAt":"2024-06-04T11:34:40.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"younesbelkada","name":"Younes Belkada","path":"/younesbelkada","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/49240599?s=80&v=4"}},{"before":"3538e8ac7ddd4f6b9e77947c3ab00c7388a1367f","after":"ad8f7cb59ee7ca4b9ca1c9048711038ac36b31b8","ref":"refs/heads/main","pushedAt":"2024-06-04T11:34:37.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"younesbelkada","name":"Younes Belkada","path":"/younesbelkada","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/49240599?s=80&v=4"},"commit":{"message":"Update build_docker_images.yml (#1823)","shortMessageHtmlLink":"Update build_docker_images.yml (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2333270734\" data-permission-text=\"Title is private\" data-url=\"https://github.com/huggingface/peft/issues/1823\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/huggingface/peft/pull/1823/hovercard\" href=\"https://github.com/huggingface/peft/pull/1823\">#1823</a>)"}},{"before":null,"after":"ca1f135e7e874feac57868be5131a5a82b8ad7eb","ref":"refs/heads/younesbelkada-patch-3","pushedAt":"2024-06-04T11:23:31.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"younesbelkada","name":"Younes Belkada","path":"/younesbelkada","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/49240599?s=80&v=4"},"commit":{"message":"Update build_docker_images.yml","shortMessageHtmlLink":"Update build_docker_images.yml"}},{"before":"b213ea5fb9feea870e5823df928a194b1471467a","after":"3538e8ac7ddd4f6b9e77947c3ab00c7388a1367f","ref":"refs/heads/main","pushedAt":"2024-06-04T11:09:10.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"BenjaminBossan","name":"Benjamin Bossan","path":"/BenjaminBossan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6229650?s=80&v=4"},"commit":{"message":"FIX CI: Install pytest-reportlog package (#1822)","shortMessageHtmlLink":"FIX CI: Install pytest-reportlog package (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2333190137\" data-permission-text=\"Title is private\" data-url=\"https://github.com/huggingface/peft/issues/1822\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/huggingface/peft/pull/1822/hovercard\" href=\"https://github.com/huggingface/peft/pull/1822\">#1822</a>)"}},{"before":"14a059a66855715a7792cc5c5e795b8859f98eba","after":null,"ref":"refs/heads/younesbelkada-patch-3","pushedAt":"2024-06-04T10:31:34.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"younesbelkada","name":"Younes Belkada","path":"/younesbelkada","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/49240599?s=80&v=4"}},{"before":"7ed94f3269448a82743a45944ee46dc445826397","after":"b213ea5fb9feea870e5823df928a194b1471467a","ref":"refs/heads/main","pushedAt":"2024-06-04T10:31:31.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"younesbelkada","name":"Younes Belkada","path":"/younesbelkada","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/49240599?s=80&v=4"},"commit":{"message":"Update tests-main.yml (#1821)","shortMessageHtmlLink":"Update tests-main.yml (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2333095686\" data-permission-text=\"Title is private\" data-url=\"https://github.com/huggingface/peft/issues/1821\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/huggingface/peft/pull/1821/hovercard\" href=\"https://github.com/huggingface/peft/pull/1821\">#1821</a>)"}},{"before":"a0788a3f92c8220f68d2185aeef0266d6b725bfe","after":"7ed94f3269448a82743a45944ee46dc445826397","ref":"refs/heads/main","pushedAt":"2024-06-04T10:18:37.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"BenjaminBossan","name":"Benjamin Bossan","path":"/BenjaminBossan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6229650?s=80&v=4"},"commit":{"message":"FIX CI: Remove potentially problematic git command (#1820)\n\nSee if this fixes the error in the workflow.\r\n\r\n> fatal: detected dubious ownership in repository at '/__w/peft/peft'","shortMessageHtmlLink":"FIX CI: Remove potentially problematic git command (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2333078665\" data-permission-text=\"Title is private\" data-url=\"https://github.com/huggingface/peft/issues/1820\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/huggingface/peft/pull/1820/hovercard\" href=\"https://github.com/huggingface/peft/pull/1820\">#1820</a>)"}},{"before":null,"after":"14a059a66855715a7792cc5c5e795b8859f98eba","ref":"refs/heads/younesbelkada-patch-3","pushedAt":"2024-06-04T09:58:11.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"younesbelkada","name":"Younes Belkada","path":"/younesbelkada","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/49240599?s=80&v=4"},"commit":{"message":"Update tests-main.yml","shortMessageHtmlLink":"Update tests-main.yml"}},{"before":"cb0bf077744d11524ec6f68d920f4cfe4ef3e8f3","after":"a0788a3f92c8220f68d2185aeef0266d6b725bfe","ref":"refs/heads/main","pushedAt":"2024-05-31T14:56:21.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"BenjaminBossan","name":"Benjamin Bossan","path":"/BenjaminBossan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6229650?s=80&v=4"},"commit":{"message":"Refactor to make DoRA and QDoRA work with FSDP (#1806)\n\nThis PR moves all the DoRA functionality into a separate module class.\r\nEssentially, this is necessary because otherwise, the DoRA parameter\r\nlives on the lora.Linear layer as a parameter, not a separate module.\r\nSince FSDP auto wrap policy operates on the level of modules, not\r\nparameters, there is no way to modify the auto wrap policy to wrap the\r\nDoRA parameter, it must be its own module.\r\n\r\nIf not for this reason, #1797 would be preferable, since the number of\r\ncode changes is smaller overall. In this PR, there are more numerous\r\nchanges, but the majority only involves moving code around, not any\r\nactual code changes.\r\n\r\nSince we introduce a new submodule, an extra steps are required to\r\nensure that old DoRA state dicts can still be loaded correctly. This\r\ninvolves a fairly trivial extra remapping step in\r\nset_peft_model_state_dict. The test for this is performed via the new\r\nregression DoRA tests introduced in #1792.\r\n\r\nSimilarly, there is a remapping step involved in\r\nget_peft_model_state_dict to ensure that when new state dicts with DoRA\r\nare saved, they still conform to the old format.\r\n\r\nAn additional required change was to make a defensive copy of the base\r\nlayer before dequantizing its weight in order to calculate the weight\r\nnorm for DoRA. Without this defensive copy, some side-effect is\r\ntriggered in FSDP that results in\r\n\r\n> ValueError: Cannot flatten integer dtype tensors\r\n\r\neven though the compute dtype of bnb is correctly set to float.\r\n\r\nCreating a fully functioning deepcopy does currently not work with 8bit\r\nBNB but there is a fix. Once the next BNB release is out, 8bit BNB will\r\nbe tested and enabled.\r\n\r\nWhile working on this, I also noticed a small bug that dropout was not\r\ncorrectly applied when using QDoRA. This is now also fixed.\r\n\r\nThis PR was tested successfully with FSDP and (Q)DoRA using the scripts\r\nin examples/sft/ with a modification to enable DoRA.","shortMessageHtmlLink":"Refactor to make DoRA and QDoRA work with FSDP (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2321313129\" data-permission-text=\"Title is private\" data-url=\"https://github.com/huggingface/peft/issues/1806\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/huggingface/peft/pull/1806/hovercard\" href=\"https://github.com/huggingface/peft/pull/1806\">#1806</a>)"}},{"before":"8cd2cb613bddf75e7c75e39546fefc87bc799809","after":"cb0bf077744d11524ec6f68d920f4cfe4ef3e8f3","ref":"refs/heads/main","pushedAt":"2024-05-30T13:39:26.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"BenjaminBossan","name":"Benjamin Bossan","path":"/BenjaminBossan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6229650?s=80&v=4"},"commit":{"message":"MNT Remove deprecated use of load_in_8bit (#1811)\n\nDon't pass load_in_8bit to AutoModel.from_pretrained, instead use\r\nBitsAndBytesConfig.\r\n\r\nThere was already a PR to clean this up (#1552) but a slightly later\r\nPR (#1518) re-added this usage.\r\n\r\n---------\r\n\r\nCo-authored-by: Younes Belkada <49240599+younesbelkada@users.noreply.github.com>","shortMessageHtmlLink":"MNT Remove deprecated use of load_in_8bit (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2325250963\" data-permission-text=\"Title is private\" data-url=\"https://github.com/huggingface/peft/issues/1811\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/huggingface/peft/pull/1811/hovercard\" href=\"https://github.com/huggingface/peft/pull/1811\">#1811</a>)"}},{"before":"e7b75070c72a88f0f7926cc6872858a2c5f0090d","after":"8cd2cb613bddf75e7c75e39546fefc87bc799809","ref":"refs/heads/main","pushedAt":"2024-05-30T10:37:18.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"BenjaminBossan","name":"Benjamin Bossan","path":"/BenjaminBossan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6229650?s=80&v=4"},"commit":{"message":"CI Make torch compile tests run on GPU (#1808)\n\nMany of these tests require a GPU to run, so use custom runners.\r\n\r\nCode was mostly copied from existing workflows.\r\n\r\n---------\r\n\r\nCo-authored-by: Younes Belkada <49240599+younesbelkada@users.noreply.github.com>","shortMessageHtmlLink":"CI Make torch compile tests run on GPU (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2322968987\" data-permission-text=\"Title is private\" data-url=\"https://github.com/huggingface/peft/issues/1808\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/huggingface/peft/pull/1808/hovercard\" href=\"https://github.com/huggingface/peft/pull/1808\">#1808</a>)"}},{"before":"1b262167f39b5f454624180bf01947a7e2ba1d65","after":"e7b75070c72a88f0f7926cc6872858a2c5f0090d","ref":"refs/heads/main","pushedAt":"2024-05-28T09:36:38.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"BenjaminBossan","name":"Benjamin Bossan","path":"/BenjaminBossan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6229650?s=80&v=4"},"commit":{"message":"TST: Add simple BNB regression tests (#1602)\n\nThese are very basic and simplistic regression tests for bnb. Their\r\npurpose is to ensure that there is no unnoticed change in bnb that leads\r\nto different outputs. There is no check for \"correctness\", just that the\r\nresults haven't changed.\r\n\r\nEventually, this workflow should be improved and moved to the bnb repo.\r\n\r\n---------\r\n\r\nCo-authored-by: Younes Belkada <49240599+younesbelkada@users.noreply.github.com>","shortMessageHtmlLink":"TST: Add simple BNB regression tests (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2213470927\" data-permission-text=\"Title is private\" data-url=\"https://github.com/huggingface/peft/issues/1602\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/huggingface/peft/pull/1602/hovercard\" href=\"https://github.com/huggingface/peft/pull/1602\">#1602</a>)"}},{"before":"4fbc7a1eb14095619c0ba3fd25d6d0ef438bf1da","after":null,"ref":"refs/heads/fix-lora-merge-docs","pushedAt":"2024-05-28T09:15:46.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"BenjaminBossan","name":"Benjamin Bossan","path":"/BenjaminBossan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6229650?s=80&v=4"}},{"before":"39c60ffca9c1d1cc606a16654cfe9cd66b363a70","after":"1b262167f39b5f454624180bf01947a7e2ba1d65","ref":"refs/heads/main","pushedAt":"2024-05-28T09:13:44.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"younesbelkada","name":"Younes Belkada","path":"/younesbelkada","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/49240599?s=80&v=4"},"commit":{"message":"Docs / LoRA: Add more information on `merge_and_unload` docs (#1805)\n\n* put back lora merging diagram\r\n\r\n* push\r\n\r\n* Update docs/source/developer_guides/lora.md\r\n\r\nCo-authored-by: Benjamin Bossan <BenjaminBossan@users.noreply.github.com>\r\n\r\n---------\r\n\r\nCo-authored-by: Benjamin Bossan <BenjaminBossan@users.noreply.github.com>","shortMessageHtmlLink":"Docs / LoRA: Add more information on <code>merge_and_unload</code> docs (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2320496523\" data-permission-text=\"Title is private\" data-url=\"https://github.com/huggingface/peft/issues/1805\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/huggingface/peft/pull/1805/hovercard\" href=\"https://github.com/huggingface/peft/pull/1805\">#1805</a>)"}},{"before":"30e87b9f6b537cea41bb9f24888af0743beaa383","after":"4fbc7a1eb14095619c0ba3fd25d6d0ef438bf1da","ref":"refs/heads/fix-lora-merge-docs","pushedAt":"2024-05-28T09:09:54.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"younesbelkada","name":"Younes Belkada","path":"/younesbelkada","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/49240599?s=80&v=4"},"commit":{"message":"Update docs/source/developer_guides/lora.md\n\nCo-authored-by: Benjamin Bossan <BenjaminBossan@users.noreply.github.com>","shortMessageHtmlLink":"Update docs/source/developer_guides/lora.md"}},{"before":"889b6f03ac1db65cf1fc1e4e6cfc33cd5a1e6b2a","after":"30e87b9f6b537cea41bb9f24888af0743beaa383","ref":"refs/heads/fix-lora-merge-docs","pushedAt":"2024-05-28T08:50:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"younesbelkada","name":"Younes Belkada","path":"/younesbelkada","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/49240599?s=80&v=4"},"commit":{"message":"push","shortMessageHtmlLink":"push"}},{"before":null,"after":"889b6f03ac1db65cf1fc1e4e6cfc33cd5a1e6b2a","ref":"refs/heads/fix-lora-merge-docs","pushedAt":"2024-05-28T08:48:47.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"younesbelkada","name":"Younes Belkada","path":"/younesbelkada","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/49240599?s=80&v=4"},"commit":{"message":"put back lora merging diagram","shortMessageHtmlLink":"put back lora merging diagram"}},{"before":"8304017a9a57175125f04a1275b7833de722a4b5","after":"39c60ffca9c1d1cc606a16654cfe9cd66b363a70","ref":"refs/heads/main","pushedAt":"2024-05-27T10:00:47.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"BenjaminBossan","name":"Benjamin Bossan","path":"/BenjaminBossan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6229650?s=80&v=4"},"commit":{"message":"TST Add regression test for DoRA, VeRA, BOFT, LNT (#1792)\n\nThese new methods were added but the regression tests were not extended\r\nyet. This PR adds regression tests for these methods. The regression\r\nartifacts have been pushed based on PEFT v0.11.1. The new tests pass\r\nlocally.","shortMessageHtmlLink":"TST Add regression test for DoRA, VeRA, BOFT, LNT (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2310614629\" data-permission-text=\"Title is private\" data-url=\"https://github.com/huggingface/peft/issues/1792\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/huggingface/peft/pull/1792/hovercard\" href=\"https://github.com/huggingface/peft/pull/1792\">#1792</a>)"}},{"before":"b2922565c4c4445706a87cf7b988c828b451fe61","after":"8304017a9a57175125f04a1275b7833de722a4b5","ref":"refs/heads/main","pushedAt":"2024-05-27T08:12:22.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"BenjaminBossan","name":"Benjamin Bossan","path":"/BenjaminBossan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6229650?s=80&v=4"},"commit":{"message":"FIX BOFT device error after PR 1742 (#1799)\n\nPR #1742 introduced the feature that adapters of the same layer can be\r\non different devices. A new method was introduced that is responsible\r\nfor moving the parameters related to a specific adapter in a consistent\r\nway.\r\n\r\nIn BOFT, however, one parameter was overlooked, boft_P. This parameter\r\nis not stored inside a ParameterDict or ModuleDict, hence it was not\r\nmoved. The reason is (presumably) that this parameter is shared between\r\nall BOFT adapters, as it's always identical. However, this clashes with\r\nhaving different adapters on different devices.\r\n\r\nTo solve this, the parameter is now moved on the fly to the correct\r\ndevice during the forward pass.","shortMessageHtmlLink":"FIX BOFT device error after PR 1742 (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2314872504\" data-permission-text=\"Title is private\" data-url=\"https://github.com/huggingface/peft/issues/1799\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/huggingface/peft/pull/1799/hovercard\" href=\"https://github.com/huggingface/peft/pull/1799\">#1799</a>)"}},{"before":"3cf5359f112fedae2ffd28412cfc95076263e5d3","after":"b2922565c4c4445706a87cf7b988c828b451fe61","ref":"refs/heads/main","pushedAt":"2024-05-23T14:12:57.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"BenjaminBossan","name":"Benjamin Bossan","path":"/BenjaminBossan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6229650?s=80&v=4"},"commit":{"message":"TST Install bitsandbytes for compile tests (#1796)\n\nAlso, remove outdated comment.","shortMessageHtmlLink":"TST Install bitsandbytes for compile tests (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2312375502\" data-permission-text=\"Title is private\" data-url=\"https://github.com/huggingface/peft/issues/1796\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/huggingface/peft/pull/1796/hovercard\" href=\"https://github.com/huggingface/peft/pull/1796\">#1796</a>)"}},{"before":"cb7aedd9ba6642dda543d176ead5b5247d112e2e","after":"3cf5359f112fedae2ffd28412cfc95076263e5d3","ref":"refs/heads/main","pushedAt":"2024-05-23T08:54:41.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"BenjaminBossan","name":"Benjamin Bossan","path":"/BenjaminBossan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6229650?s=80&v=4"},"commit":{"message":"FIX Allow same layer adapters on different devices (#1742)\n\nThe issue is that so far, we made the assumption in PEFT that all\r\nadapter weights of a specific layer are on the same device. There can be\r\ncases where it is useful to have adapters on different devices. E.g.\r\nwhen a user loads a lot of LoRA adapters and wants to offload those not\r\ncurrently in use to CPU, they would not currently be able to do so.\r\n\r\nWith this PR, we add this possibility. To achieve this, when we update\r\nan adapter layer with a new adapter, we only move that specific adapter\r\nto the device of the base layer, will not touching the other loaded\r\nadapters.\r\n\r\nWhile working on this, I discovered a small bug in VeRA when adding\r\nmultiple adapters, which is now also fixed.","shortMessageHtmlLink":"FIX Allow same layer adapters on different devices (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2302778789\" data-permission-text=\"Title is private\" data-url=\"https://github.com/huggingface/peft/issues/1742\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/huggingface/peft/pull/1742/hovercard\" href=\"https://github.com/huggingface/peft/pull/1742\">#1742</a>)"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEX1KWnAA","startCursor":null,"endCursor":null}},"title":"Activity · huggingface/peft"}