Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throwing application to another space is broken. #1643

Closed
JS211 opened this issue May 14, 2024 · 48 comments · Fixed by #1648
Closed

Throwing application to another space is broken. #1643

JS211 opened this issue May 14, 2024 · 48 comments · Fixed by #1648
Labels
Milestone

Comments

@JS211
Copy link

JS211 commented May 14, 2024

Describe the bug
Updated to Mac OS 14.5 which caused throwing applications to different spaces to stop working and crash amethyst v0.20. Updated to amethyst v0.21 and it no longer crashes but throwing apps to different spaces still doesn’t work.
Applications:
What applications are involved?
Any application

To Reproduce
Assign a shortcut to throw current application to space 1, 2, or 3.
Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Versions:

  • macOS: 14.5
  • Amethyst: 0.20, 0.21

Debug Info

$ /Applications/Amethyst.app/Contents/MacOS/Amethyst --debug-info [--include-apps]

Note: --include-apps will list your manageable applications, but is optional if you don't want to list that.

Additional context
Add any other context about the problem here.

@joshuaalderson
Copy link

joshuaalderson commented May 15, 2024

After updating to 14.5 I am also experiencing the same issue. 14 inch M3 MacBook, Amethyst Version 0.20.0 (108)

When trying to use the keyboard shortcut to send a window to another screen it sends it and then sends it back to the original display instantly. Interestingly moving the window with the trackpad to another display still seems to work however.

I've tried relaunching the Amethyst app, completely closing/quitting the app and opening again and still doesn't work. I've also tried different displays and have the same issue.

@ianyh
Copy link
Owner

ianyh commented May 15, 2024

Dang. I'll upgrade and give it a go. The APIs probably changed in some way.

@hpfmn
Copy link

hpfmn commented May 15, 2024

FYI: yabai has the same issue. I would also think that something about SkyLight did change. My problem is that I don’t know much about how this framework works. I guess SLSMoveWindowsToManagedSpace is our problem here. I think you use this function as well?

@dee-kryvenko
Copy link

Got the same problem. Interesting that if I have Amethyst disabled, the key combination still makes my screen flicker and the tab bar briefly change the title of the focused screen to something else, although it happens so quick that you can't really read it. I recorded it and in the recording I can see it changes to Finder and back.

@joshuaalderson
Copy link

joshuaalderson commented May 17, 2024

Just to add on to the above; when I disable Amethyst moving apps to different windows using the keyboard shortcut actually works? Perhaps this is obvious to others but I thought disabling Amethyst would disable this functionality. Of course the windows margin stuff doesn't work but at least for now I can get the keyboard shortcuts working to move app windows to different screens

@phrmendes
Copy link

Same problem here. Also, I believe that this issue is related to this bug.

@porkloin
Copy link

+1, I have one machine on 14.4.1 with no issues, another on 14.5 where I can no longer throw windows to other spaces, exact same config otherwise.

@porkloin
Copy link

FWIW, it seems like the yabai folks found a temporary solution: koekeishiya/yabai#2240 (comment)

Bad news is that it looks like the API change may require SIP to be disabled, which is a huge problem for people working on employer-owned hardware that can't be modified like that. 😬

@ianyh
Copy link
Owner

ianyh commented May 18, 2024

Yeah, I'm not particularly surprised, honestly. Seemed like a matter of time before the private APIs got locked down. If history is any indication, Apple will probably lock it down and then immediately launch their new tiling window manager, macOS Flow or something. 😂

I'll try to apply yabai's fix for now, and hope for the best.

@kolchurinvv
Copy link

Raycast's window management is still intact. throwing to next display and to next desktop works just fine somehow on 14.5

@Ryan-the-hito
Copy link

Raycast's window management is still intact. throwing to next display and to next desktop works just fine somehow on 14.5

For me, Raycast is also dead. It can only move its own Setting window but leaves other windows still.

@kolchurinvv
Copy link

kolchurinvv commented May 22, 2024

@Ryan-the-hito - i double checked and you're right. it was able to throw a focused window to the next display, but that could be related to the fact the the dock i'm using requires display link software. when unplugged from the dock raycast behaves exactly like you describe

@escherlies
Copy link

escherlies commented May 23, 2024

Same problem here. Also, I believe that this issue is related to this bug.

I think too, i noticed the thrown window looses focus which makes it broken.

Also FYI, I just rolled back to Amethyst v0.20.0 (108) and everything's working fine again.

EDIT: Still using MacOS 14.4.1

@svrdlans
Copy link

Also FYI, I just rolled back to Amethyst v0.20.0 (108) and everything's working fine again.

I tried going back to v0.20.0 on Sonoma 14.5, it allows me to throw window between screens (laptop - monitor), but doesn't seem to be aware of Spaces and can't throw window to different Spaces on the same screen

for now I drag-drop to specific Spaces ¯_(ツ)_/¯

@Ryan-the-hito
Copy link

@svrdlans I tried the latest BetterTouchTool and it is still working. I guess it uses a different way to send windows to different spaces. So now I am assigning the original shortcuts in the BetterTouchTool. 😀

@escherlies
Copy link

Also FYI, I just rolled back to Amethyst v0.20.0 (108) and everything's working fine again.

I tried going back to v0.20.0 on Sonoma 14.5, it allows me to throw window between screens (laptop - monitor), but doesn't seem to be aware of Spaces and can't throw window to different Spaces on the same screen

for now I drag-drop to specific Spaces ¯_(ツ)_/¯

Ah thanks for clarification!

I am still on 14.4.1... So I think I'll wait for the update 😅

@denisbr
Copy link

denisbr commented May 24, 2024

Apparently yabai was able to restore space throwing functionality?
koekeishiya/yabai#2240 (comment)

@HanSooloo
Copy link

On macOS 14.5 and after getting the 0.21 update lost ability to throw windows to spaces. When I used the shortcut key, the window flashes for a split second and doesn't move. Stays in the same screen.
When I reverted back to Amethyst 0.20, the flashing doesn't happen, but throwing to a space doesn't work either.

I wonder if this points to a macOS 14.4 ==> 14.5 issue.

@aleksozolins
Copy link

Friends it is broken for me as well. I hope for a fix soon but do not have the ability myself.

@Vinh-CHUC
Copy link

broken for me too! hoping for a fix too :)

@HanSooloo
Copy link

HanSooloo commented May 26, 2024 via email

@timvisher
Copy link
Contributor

Please don't comment with a 'broken for me too' message. That's what the 👍 button at the top of the issue is for. Thanks in advance!

@ianyh
Copy link
Owner

ianyh commented May 27, 2024

Implemented the fix, which functions on 14.4.1. Need to test on 14.5 still.

@tlpierce
Copy link

If you have Keyboard Maestro, you can use a macro to throw windows between desktops as a workaround. This is what I'm currently doing. I unmapped the "Throw focused window to space..." in Amethyst preferences and mapped the same keystroke to the appropriate macro in Keyboard Maestro.

@ianyh ianyh added this to the 0.21.1 milestone May 28, 2024
@ipstone
Copy link

ipstone commented May 28, 2024

@ianyh Thank you for the quick fix! - I tested it on 14.5, it works well now.

@joshuaalderson
Copy link

Thanks a lot for the quick fix - working here to on 14.5 after updating

@dfucci
Copy link

dfucci commented May 28, 2024

Thanks a lot for the quick fix - working here to on 14.5 after updating

How do you get the fix? I have "Get development builds" enabled, but no updates after "Check for Updates..."

@Vinh-CHUC
Copy link

@dfucci same for me, then I realised I had installed it through Homebrew needed to update through that. Maybe it's the same for you?

@Vinh-CHUC
Copy link

Vinh-CHUC commented May 28, 2024

@ipstone @joshuaalderson in my case it doesn't work on sonoma 14.5 :(
@ianyh

Screenshot 2024-05-28 at 11 23 25
Screenshot 2024-05-28 at 11 23 18

I even rebooted to be sure.. Could this depend on something else also??

@pjezek
Copy link

pjezek commented May 28, 2024

@Vinh-CHUC I downloaded it from the release page: releases/tag/v0.21.1.
Windows lands on new space, and I am back from where I send it -> Looks like it works again.

@claviola
Copy link

@ianyh thanks for the fix! but I've noticed that this when I had Safari in full-screen somewhere, throwing a selected window still didn't work. Maybe this has always been the case, but I thought it was worth mentioning.

@Cerebus
Copy link

Cerebus commented May 28, 2024

I have no full-screen windows and throwing with 0.21.1 and macOS 14.5 still not working for me.

@porkloin
Copy link

Just downloaded the latest Github release and throwing spaces is working great for me!

@phrmendes
Copy link

phrmendes commented May 28, 2024

I'ts fixed for me, thanks @ianyh ❤️

@ipstone
Copy link

ipstone commented May 28, 2024

@ipstone @joshuaalderson in my case it doesn't work on sonoma 14.5 :( @ianyh

Screenshot 2024-05-28 at 11 23 25 Screenshot 2024-05-28 at 11 23 18

I even rebooted to be sure.. Could this depend on something else also??

I was on a M1 mac mini, the fix worked for me for 14.5 - did you download from the latest built?

@yougotwill
Copy link

I think the fix works on aarch64 (Apple Silicon) but not on Intel machines for some reason 🤔

@ianyh
Copy link
Owner

ianyh commented May 28, 2024

It could conceivably be a chip architecture thing. I can look into that, but I don't think I have access to any Intel machines at this point.

@cgrindel
Copy link

cgrindel commented May 29, 2024

@ianyh I have an x86_64 Mac. I just built and ran Amethyst from Xcode. I see this in the log when I attempt to throw a window to another space:

18:01:45.324 ❤️ ERROR Window.move():394 - failed to set compat aside id: CGError(rawValue: -944701316)

I will do some digging. However, if you have any pointers, please let me know.

@cgrindel
Copy link

cgrindel commented May 29, 2024

Interestingly. The raw value for the error can be different:

18:41:33.725 ❤️ ERROR Window.move():401 - failed to set compat aside id: CGError(rawValue: -1194852224)

Note: The line number keeps moving around because I added some other debug code.

@ianyh
Copy link
Owner

ianyh commented May 29, 2024

@koekeishiya does the compat id thing, in fact, only still work on Apple Silicon? That's so annoying.

@koekeishiya
Copy link

Works in Intel and Apple Silicon for me.

@blue-3
Copy link

blue-3 commented May 29, 2024

same issue as @cgrindel
i have intel and apple silicon, and the fix only works on silicon for me

@ianyh
Copy link
Owner

ianyh commented May 29, 2024

Works in Intel and Apple Silicon for me.

Does SIP make a difference?

@simonbernard-shopify
Copy link

simonbernard-shopify commented May 29, 2024

On Sonoma 14.5 and running Amethyst 0.21.0 (110) and I can't throw windows to other spaces. I can throw them to external monitors though.

Edit: Actually nevermind, downloading the latest patch from https://github.com/ianyh/Amethyst/releases fixed it. Thanks @ianyh!

@ja-versent
Copy link

@ianyh i don't have SIP disabled on my intel mac if that's the differentiator
i can try and get debug logs later to try illuminate the issue

@ianyh
Copy link
Owner

ianyh commented May 29, 2024

That's a good definitive datapoint thank you.

@claviola
Copy link

I also have access to a Mac on Intel and can try to repro later if you need more data.

@Cerebus
Copy link

Cerebus commented May 30, 2024

I suggest @ianyh lock this issue and direct over to #1655.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.