Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contribution guide and documentation #126

Open
tanujjain opened this issue Dec 4, 2020 · 0 comments
Open

Update contribution guide and documentation #126

tanujjain opened this issue Dec 4, 2020 · 0 comments
Assignees
Labels
bug Something isn't working QA Requires enrichment or quality assurance

Comments

@tanujjain
Copy link
Collaborator

In the contribution guide, add the following:

  1. Use of single quotes instead of double
  2. import order and groups as specified python org (https://www.python.org/dev/peps/pep-0008/#imports). Also mention that regardless of import form, all imports from the same dependency are to be put in consequent lines.

In the documentation, update the find_duplicates documentation to reflect that encoding_map parameter of find_duplicates expects the value in the dictionary to be of shape (1024,). This led to a confusion as reported in #114

@tanujjain tanujjain self-assigned this Dec 4, 2020
@tanujjain tanujjain added bug Something isn't working QA Requires enrichment or quality assurance labels Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working QA Requires enrichment or quality assurance
Projects
None yet
Development

No branches or pull requests

1 participant