Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: ES sql no restrict for docnm_kwd #729

Open
1 task done
yonghuili1 opened this issue May 11, 2024 · 2 comments
Open
1 task done

[Bug]: ES sql no restrict for docnm_kwd #729

yonghuili1 opened this issue May 11, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@yonghuili1
Copy link
Contributor

Is there an existing issue for the same bug?

  • I have checked the existing issues.

Branch name

main

Commit ID

33eaf6f

Other environment information

runtime: SourceCode
OS type: CentOS

Actual behavior

At present, it seems that all documents will be stored in ES (one table for each user, and all documents in the current user's knowledge base are in this table).

However, when different assistants are associated with different knowledge bases, should the text2SQL query limit docnm_kwd to the docnm_kwd of the current associated knowledge base. Now it seems that there are no restrictions. If there are no errors during SQL execution, the output may be a pile of meaningless content. Even the referenced document displayed has no relation to the currently referenced knowledge base document.

image

image

Expected behavior

add "docnm_kwd" restrict for es sql

Steps to reproduce

I saw this issue https://github.com/infiniflow/ragflow/issues/559 which does not recommend mixing 'table' chunking method with other chunking methods. But I always think this restriction should be added

Additional information

No response

@yonghuili1 yonghuili1 added the bug Something isn't working label May 11, 2024
@KevinHuSh
Copy link
Collaborator

The 'docnm_kwd' will be used for the little exclamation mark by hovering which we can identify the source of the given row.

@yonghuili1
Copy link
Contributor Author

Anyway, I believe that there should be no references unrelated to the current associated knowledge base

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants