Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests to the project #4872

Open
Airthee opened this issue Oct 12, 2023 · 1 comment · May be fixed by #5412
Open

Add tests to the project #4872

Airthee opened this issue Oct 12, 2023 · 1 comment · May be fixed by #5412
Labels
enhancement Improve existing functionality or small fixes

Comments

@Airthee
Copy link

Airthee commented Oct 12, 2023 •
edited

Hi !

I see that the project is not covered by tests, am I missing something ?
I think it would be very important to cover the project with tests.
I know it's a big job, but we need it to stop regressions, improve stability and maintainability.
Tests also help to understand the code (to get more contributors — like me).
Do you need more arguments ?

I volunteer to do it.

I suggest one PR per covered file.
I will be easy for people to help, by commenting on this post wich file they take.
@Airthee Airthee added the enhancement Improve existing functionality or small fixes label Oct 12, 2023
@thornbill
Copy link
Member

Yes tests would be great! (You really don't need to convince us. 😉) Unfortunately I think a lot of the legacy code will be virtually impossible to cover with unit tests due to dependencies on side effects. However there has been some movement on a couple different testing initiatives just in the past week!

  1. Unit tests:
    • Support for writing tests with vitest is now available.
    • Currently the only test is for cardBuilderUtils
    • It would probably be easiest to start writing tests for the utils files since they should be mostly self contained.
  2. End-to-end tests:

@Airthee Airthee linked a pull request Apr 23, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improve existing functionality or small fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

draft: Add unit tests Airthee/jellyfin-web
2 participants
@thornbill @Airthee