New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NeedNewTest] 42filechecker doesn't check memory allocation on strjoin #121

Open

EPgg92 opened this issue Oct 18, 2018 · 1 comment

Assignees

Labels

EPgg92 commented Oct 18, 2018

#include "libft.h"

char	*ft_strjoin(char const *s1, char const *s2)
{
	char	*res;

	if (s1 == NULL || s2 == NULL)
		return (NULL);
	if (!(res = ft_strnew(ft_strlen((char *)s1 + ft_strlen((char *)s2 + 1))))) // +1 is very bad but 42fc don' t check it!
		return (NULL);
	res = ft_strcpy(res, s1);
	res = ft_strcat(res, s2);
	return (res);
}

Thx

The text was updated successfully, but these errors were encountered:

jgigault added the enhancement label

Owner

jgigault commented Jan 13, 2019

Hello @EPgg92
The idea to check for leaks on "libft" project is nice.
Are you interested in developing this test?

jgigault self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment