Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for InfluxQL #5445

Closed
danielwhatmuff opened this issue Jan 30, 2024 · 8 comments · May be fixed by #5513
Closed

Add support for InfluxQL #5445

danielwhatmuff opened this issue Jan 30, 2024 · 8 comments · May be fixed by #5513
Assignees
@danielwhatmuff
Labels
needs-discussion scaler stale All issues that are marked as stale due to inactivity

Comments

@danielwhatmuff
Copy link

Proposal

The new version of InfluxDB (v3.0/clustered) does not support Flux queries and therefore the existing scaler cannot be used. This proposal related to adding support for scaling based on an InfluxQL query either within the existing Influx scaler by extending it, possibly with an additional parameter e.g. queryType or in a new scaler altogether.

Scaler Source

Influxdb v3.0

Scaling Mechanics

An InfluxQL query

Authentication Source

API token

Anything else?

Would be good to get feedback on the approach and may be able to submit a PR
@JorTurFer
Copy link
Member

Hey!
This is a great idea! I guess that adding a new parameter to switch between old and new protocols makes sense.
Are you willing to work on this?

@danielwhatmuff
Copy link
Author

ok great, yes either me or someone on my team can look at this

@danielwhatmuff
Copy link
Author

@JorTurFer I've got this implemented now and its passing all the tests, we're just going to do some further testing with it deployed to a cluster/wired up to influx and then will raise a PR.

@JorTurFer
Copy link
Member

Thanks for the update! ❤️

@zroubalik
Copy link
Member

@danielwhatmuff great!

@danielwhatmuff danielwhatmuff mentioned this issue Feb 15, 2024
Open
@danielwhatmuff
Copy link
Author

@zroubalik @JorTurFer appreciate any feedback

kedacore/keda-docs#1318
#5513

@stale Stale
Copy link

stale bot commented Apr 17, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Apr 17, 2024
@stale Stale
Copy link

stale bot commented Apr 25, 2024

This issue has been automatically closed due to inactivity.

@stale stale bot closed this as completed Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielwhatmuff danielwhatmuff

Labels
needs-discussion scaler stale All issues that are marked as stale due to inactivity
Projects
Roadmap - KEDA Core
Status: Ready To Ship
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding support for influx v3 in the influx scaler danielwhatmuff/keda
3 participants
@zroubalik @danielwhatmuff @JorTurFer