Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Checker: Art is not consistent #10310

Open
JustLuuuu opened this issue May 16, 2024 · 8 comments
Open

Code Checker: Art is not consistent #10310

JustLuuuu opened this issue May 16, 2024 · 8 comments
Assignees
Labels
A-code-checker issues related to generative art code checker bug Something isn't working

Comments

@JustLuuuu
Copy link
Member

JustLuuuu commented May 16, 2024

'Art Is not Consistent' Artist is using hash to seed from our template: randomSeed(seed) and he is still getting this error.

Code:
hopa (1).zip

Where can the issue be? I cannot review his code as Im not sure what Im looking for. @daiagi I added you as you are behinf the code-checker :)

@JustLuuuu JustLuuuu added bug Something isn't working A-code-checker issues related to generative art code checker labels May 16, 2024
@daiagi
Copy link
Contributor

daiagi commented May 16, 2024

findings:

  1. this does not happen (with this art at least) on Firefox - not much help, can't tell artists to use other browsers

  2. this is a problem that has been raised before with @vikiival , here.
    Base64 of visually same images, can be not same => failing the test.

as a one off solution - can reassure the artist that this artwork is consistent (i checked it many times, it's ok)

as a more robust solution i offer we add a check mark to toggle the more intensive , image to image comparison

the idea is

  1. pour both base64 onto canvases
  2. convert to grey scale
  3. compare pixel by pixel
  4. declare ok if diff is within acceptable margin (95% same for example)

this solution was previously implemented here

@vikiival waiting for your call on this

@vikiival
Copy link
Member

Honestly think that it could be implemented by art
vikiival/kodahash#5

@JustLuuuu
Copy link
Member Author

kodahash-main 10.zip
another artist (Reza Milani) most likely has the same issue. Just fyi

@daiagi
Copy link
Contributor

daiagi commented May 17, 2024

kodahash-main 10.zip another artist (Reza Milani) most likely has the same issue. Just fyi

Very Beautiful art

takes clearly longer then 3 seconds
but it is consistent

@JustLuuuu
Copy link
Member Author

@daiagi

How about this: is it consistent? It's showing that it's not, but idk. Loading time is more than 3 secs but this is okay as the art is endless animation.

Screenshot 2024-05-20 at 11 44 12

project.zip

@daiagi
Copy link
Contributor

daiagi commented May 20, 2024

After this

vikiival/kodahash#6

Gets merged, we will be able to fix the problem easily.

Until then, did you look at it? @JustLuuuu ?

If it looks consistent, then it is

@vikiival
Copy link
Member

Gets merged,

It needs to be implemented by the artist anyway.

If it looks consistent, then it is

Have you tested the public.zip above ?

@daiagi
Copy link
Contributor

daiagi commented May 20, 2024

Have you tested the public.zip above ?

it's consistent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-code-checker issues related to generative art code checker bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants