Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sleep screen image always assumes portrait orientation, even when reading in landscape #11856

Open
yfede opened this issue May 19, 2024 · 4 comments

Comments

@yfede
Copy link

yfede commented May 19, 2024

  • KOReader version: 2024.04
  • Device: Kobo Aura (model N514)

Issue

Sleep screen image is always displayed in portrait orientation, even when the book was being read in landscape

If a message string is set, the string as well is displayed in portrait mode, i.e. the base of the string is parallel to the short side of the kobo, not the long one

Steps to reproduce

  1. Set reading orientation to landscape
  2. Set a sleep screen image that is 1024 px wide by 768 pixels high
  3. Put the device to sleep

Expected result:

The image in the sleep screen should fill the whole display, with the long side of the image aligned with the long side of the device, like this (this is how the image is displayed when opened with the viewer):

image

Actual result:

The image is scaled down, displayed in the center of the screen, with the long side of the image aligned with the short side of the device

image

Final note:

You may say: "why don't you save your image with a rotation to compensate for the above behavior, so that it is 768 px wide and 1024 px high?"

That may work for solving the problem of the image itself, but the string message would still be displayed conforming to the portrait orientation, while I would like it to appear at the bottom of the image in landscape mode, in order to take advantage of the bigger length of the long side of the device

@yfede
Copy link
Author

yfede commented May 19, 2024

If it's problematic to obtain/retain the current reading orientation and apply it to the sleep screen, an equally satisfactory solution would be IMHO to add an explicit setting in the recently overhauled "sleep screen" menu, to indicate the intended orientation of the sleep screen

@pazos
Copy link
Member

pazos commented May 19, 2024

Final note:

You may say: "why don't you save your image with a rotation to compensate for the above behavior, so that it is 768 px wide and 1024 px high?"

That may work for solving the problem of the image itself, but the string message would still be displayed conforming to the portrait orientation, while I would like it to appear at the bottom of the image in landscape mode, in order to take advantage of the bigger length of the long side of the device

That's the expected behaviour. Sleep message/stats/picture/.., booting KOReader from KFMon, USBnet... All work on the native orientation. That's 0º.

While it might be yet another good feature for somebody I would suggest to implement it as an user patch.

@yfede
Copy link
Author

yfede commented May 20, 2024

but... if the sleep screen is set to show the reading statistics, then it follows the reading orientation instead (see proof below), so it doesn't seem mandatory to respect the native orientation in the sleep screen after all, or am I missing something?

20240520_211746
20240520_211801

20240520_211840
20240520_211857

@mergen3107
Copy link
Contributor

Reading statistics (I believe) is a screenshot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants