Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please add the --kubeconfig arg to the helm chart (kube-webhook-certgen) so we can point to external cluster #6098

Open
Blackmamba23 opened this issue Jun 8, 2023 · 6 comments · May be fixed by #6237 or #6448
Open

Please add the --kubeconfig arg to the helm chart (kube-webhook-certgen) so we can point to external cluster #6098

Blackmamba23 opened this issue Jun 8, 2023 · 6 comments · May be fixed by #6237 or #6448
Assignees
@yashvardhanmishra
Labels
good first issue Good for newcomers priority/nice-to-have It's a good idea, but not scheduled for any release. type/enhancement New feature or request

Comments

@Blackmamba23
Copy link

Seems the the kube-webhook-certgen image supports the --kubeconfig arg but it is not possible to add it in the helm chart?

https://github.com/kubevela/kubevela/blob/c255d21ad63c879d50e3029fb72b679fe236275b/charts/vela-core/templates/cluster-gateway/job-patch.yaml#LL85C13-L85C13
@Somefive
Copy link
Collaborator

Somefive commented Jun 9, 2023

By default, we use the in-cluster kubeconfig for the kube-webhook-certgen. Is there any problem with the default kubeconfig?

@Somefive Somefive added the needs investigation the issue is not clear and need to investigate label Jun 9, 2023
@Blackmamba23
Copy link
Author

By default, we use the in-cluster kubeconfig for the kube-webhook-certgen. Is there any problem with the default kubeconfig?

Hi, it would be nice to set the kubeconfig for use cases where we need to reference an external kubernetes. Eg you could be running certgen outside the cluster. certgen already supports the flag

@Somefive
Copy link
Collaborator

I see. So it is like adding a "cert-gen-kubeconfig" parameter to the helm chart and place it in the program arguments for the cert-gen job?

@Blackmamba23
Copy link
Author

I see. So it is like adding a "cert-gen-kubeconfig" parameter to the helm chart and place it in the program arguments for the cert-gen job?

Yes please 🙏🏿

@Somefive Somefive added type/enhancement New feature or request good first issue Good for newcomers priority/nice-to-have It's a good idea, but not scheduled for any release. and removed needs investigation the issue is not clear and need to investigate labels Jun 13, 2023
@yashvardhanmishra
Copy link

I would love to work on this issue , Could you please assign this issue to me?

@chivalryq
Copy link
Member

Hi @yashvardhanmishra, I'm glad that you want to contribute to this issue. I will assign it to you.

@yashvardhanmishra yashvardhanmishra linked a pull request Jul 30, 2023 that will close this issue
Open
4 tasks
@moki1202 moki1202 linked a pull request Jan 17, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yashvardhanmishra yashvardhanmishra

Labels
good first issue Good for newcomers priority/nice-to-have It's a good idea, but not scheduled for any release. type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
4 participants
@Somefive @Blackmamba23 @chivalryq @yashvardhanmishra