Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix semvar deprication warning #1296

Closed
AyushExel opened this issue May 12, 2024 · 1 comment · Fixed by #1311
Closed

Fix semvar deprication warning #1296

AyushExel opened this issue May 12, 2024 · 1 comment · Fixed by #1311
Labels
enhancement New feature or request

Comments

@AyushExel
Copy link
Contributor

SDK

Python

Description

Cohere reranker uses semvar.compare which seems depricated

lancedb/rerankers/cohere.py:49: PendingDeprecationWarning: Function 'semver.compare' is deprecated. Deprecated since version 3.0.0. Still under investigation, see #258. Use the respective 'semver.Version.compare' instead.
and semver.compare(cohere.version, "5.0.0") < 0
@AyushExel AyushExel added the enhancement New feature or request label May 12, 2024
@pmeier
Copy link
Contributor

pmeier commented May 13, 2024

Another one comes from here

lancedb/python/python/lancedb/pydantic.py

Line 40 in b37c583

PYDANTIC_VERSION = semver.parse_version_info(pydantic.__version__) 

DeprecationWarning: Function 'semver.parse_version_info' is deprecated. Deprecated since version 2.10.0.  This function will be removed in semver 3. Use 'semver.version.Version.parse' instead.

This was referenced May 13, 2024
Closed
Merged
Merged
wjones127 added a commit that referenced this issue May 28, 2024
@pmeier @wjones127
chore: replace semver dependency with packaging (#1311)
1ad1c08 
Fixes #1296 per title. See
#1298 (comment) Cc
@wjones127

---------

Co-authored-by: Will Jones <willjones127@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@pmeier @AyushExel