fix token duplication in frontend #301
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
applyPatch modifies the document so every token got added twice to the stream Signed-off-by: Peter Suti <spatker@gmail.com>
|
@spatker is attempting to deploy a commit to the LangChain Team on Vercel. A member of the Team first needs to authorize it. |
Trde654
reviewed
Apr 28, 2024
| streamedResponse = applyPatch(streamedResponse, chunk.ops).newDocument; | ||
| streamedResponse = applyPatch(streamedResponse, chunk.ops, undefined, false).newDocument; |
Trde654
reviewed
Apr 29, 2024
| @@ -132,7 +132,7 @@ export function ChatWindow(props: { conversationId: string }) { | |||
| }, | |||
| ); | |||
| for await (const chunk of streamLog) { | |||
| streamedResponse = applyPatch(streamedResponse, chunk.ops).newDocument; | |||
| streamedResponse = applyPatch(streamedResponse, chunk.ops, undefined, false).newDocument; | |||
Trde654
suggested changes
Apr 29, 2024
| @@ -132,7 +132,7 @@ export function ChatWindow(props: { conversationId: string }) { | |||
| }, | |||
| ); | |||
| for await (const chunk of streamLog) { | |||
| streamedResponse = applyPatch(streamedResponse, chunk.ops).newDocument; | |||
| streamedResponse = applyPatch(streamedResponse, chunk.ops, undefined, false).newDocument; | |||
Trde654
reviewed
Apr 29, 2024
| @@ -132,7 +132,7 @@ export function ChatWindow(props: { conversationId: string }) { | |||
| }, | |||
| ); | |||
| for await (const chunk of streamLog) { | |||
| streamedResponse = applyPatch(streamedResponse, chunk.ops).newDocument; | |||
| streamedResponse = applyPatch(streamedResponse, chunk.ops, undefined, false).newDocument; | |||
| @@ -132,7 +132,7 @@ export function ChatWindow(props: { conversationId: string }) { | |||
| }, | |||
| ); | |||
| for await (const chunk of streamLog) { | |||
| streamedResponse = applyPatch(streamedResponse, chunk.ops).newDocument; | |||
| streamedResponse = applyPatch(streamedResponse, chunk.ops, undefined, false).newDocument; | |||
vbarda
approved these changes
May 22, 2024
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thank you @spatker! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
applyPatch modifies the document so every token got added twice to the stream
Fixes: #300