Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugifx] Vertex AI Search - Blended Search - breaking without support for some search params (temporary) #156

Open
zeroasterisk opened this issue Apr 12, 2024 · 3 comments

Comments

@zeroasterisk
Copy link

For a period of time, Vertex AI Search engine_data_type=3 (Blended search) doesn't support some search params which are defaulted to on.

    status = StatusCode.INVALID_ARGUMENT
details = "Setting query_expansion_spec, spell_correction_spec, content_search_spec proto fields is not allowed for multi-datastore search."

FR 1:
Ability to explicitly remove the search settings.
(perhaps value = -1 means don't pass in the param)

FR 2:
Default to remove for now.
While we are waiting on those features to be available, let's just get the default settings to work, and we can improve the defaults in the future.

@lkuligin
Copy link
Collaborator

thanks for bring this to our attention!
would you like to contribute / work on this one?

@zeroasterisk
Copy link
Author

I was about to start making edits and I realized that the copy in this repo is divergent from the copy in the main langchain repo

https://github.com/langchain-ai/langchain/blob/9efab3ed662fd789d2fc4f50c07ca6cb6d20a078/libs/community/langchain_community/retrievers/google_vertex_ai_search.py#L46

do you recommend a sync and then edit here, or do you recommend an edit there and then sync here?

@lkuligin
Copy link
Collaborator

here is the latest version, this integration on langchain_community is already marked as deprecated.
https://github.com/langchain-ai/langchain/blob/9efab3ed662fd789d2fc4f50c07ca6cb6d20a078/libs/community/langchain_community/retrievers/google_vertex_ai_search.py#L199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants