Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: Evaluation runs ignore child traces #548

Open
jennmueng opened this issue Mar 25, 2024 · 3 comments
Open

Issue: Evaluation runs ignore child traces #548

jennmueng opened this issue Mar 25, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@jennmueng
Copy link

Issue you'd like to raise.

We're running evaluations on a pipeline that we've already instrumented with @traceable, when those evaluations run the trace shows up fine in the normal project view:
https://smith.langchain.com/public/1480ce7d-103e-426c-b416-cef4b9c670ac/r

However, in the evaluation run's trace it's empty:
https://smith.langchain.com/public/37a27aba-ea90-4184-9686-01e302b4de6f/r

Suggestion:

Have the fully instrumented pipeline we have show up in the evaluation run so it's easier to review + show token count

@hinthornw
Copy link
Collaborator

Ah yes the handoff back to langsmith from langchain code still is manual, and the evaluation runner currently is instrumented using langchain code - I have a ticket to fix this. Does the following work for now?

from langsmith.run_helpers import as_runnable

@traceable
def my_pipeline(....):
     return ....

def predict_result(inputs: dict):
    return as_runnable(my_pipeline).invoke(inputs)


run_on_dataset(llm_or_chain_factory=predict_result, ...)

@jennmueng
Copy link
Author

@hinthornw nope, getting a wrap_traceable item with no children:
Screenshot 2024-03-26 at 1 34 15 PM

@hinthornw hinthornw added the bug Something isn't working label Apr 10, 2024
@peterjrichens
Copy link

I'm running into a similar issue when running the official Evaluation Quick Start example. I can see the llm child_run in the json, but its not visualised. Is this the same bug or different?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants