Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseRun.start_time and BaseRun.end_time should be strings #642

Open
davidfant opened this issue Apr 30, 2024 · 0 comments
Open

BaseRun.start_time and BaseRun.end_time should be strings #642

davidfant opened this issue Apr 30, 2024 · 0 comments
Assignees

Comments

@davidfant
Copy link

Today I used patch-package to patch langsmith@0.1.20 for the project I'm working on. start/end time from the API is an ISO string, not a number

Here is the diff that solved my problem:

diff --git a/node_modules/langsmith/dist/schemas.d.ts b/node_modules/langsmith/dist/schemas.d.ts
index 189a1cd..80d53ae 100644
--- a/node_modules/langsmith/dist/schemas.d.ts
+++ b/node_modules/langsmith/dist/schemas.d.ts
@@ -39,11 +39,11 @@ export interface BaseRun {
     /** A human-readable name for the run. */
     name: string;
     /** The epoch time at which the run started, if available. */
-    start_time?: number;
+    start_time?: string;
     /** Specifies the type of run (tool, chain, llm, etc.). */
     run_type: string;
     /** The epoch time at which the run ended, if applicable. */
-    end_time?: number;
+    end_time?: string;
     /** Any additional metadata or settings for the run. */
     extra?: KVMap;
     /** Error message, captured if the run faces any issues. */

This issue body was partially generated by patch-package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants