Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add token usage parsing for Google Vertex AI models #683

Merged
merged 6 commits into from
May 23, 2024
Merged

add token usage parsing for Google Vertex AI models #683

merged 6 commits into from
May 23, 2024

Conversation

shenghann
Copy link
Contributor

@shenghann
Copy link
Contributor Author

@marcklingen @maxdeichmann for some visibility on this PR - any comments?

@marcklingen marcklingen requested review from maxdeichmann and hassiebp and removed request for maxdeichmann May 22, 2024 12:36
@hassiebp hassiebp changed the base branch from main to hassieb/lfe-1241 May 23, 2024 13:53
@hassiebp hassiebp merged commit b5bf595 into langfuse:hassieb/lfe-1241 May 23, 2024
3 of 8 checks passed
@hassiebp
Copy link
Contributor

Thanks a lot for your contribution, @shenghann!

hassiebp added a commit that referenced this pull request May 23, 2024
@hassiebp @shenghann
add token usage parsing for Google Vertex AI models (#683) (#701)
65ea0e1 
* add usage parsing for vertex AI models

* Update langchain.py

---------

Co-authored-by: Sheng Han Lim <shenghan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hassiebp hassiebp hassiebp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: capture token counts from google vertex in langchain-python
2 participants
@shenghann @hassiebp