Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dify helm chart #2931

Closed
4 tasks done
LeoQuote opened this issue Mar 21, 2024 · 3 comments
Closed
4 tasks done

Dify helm chart #2931

LeoQuote opened this issue Mar 21, 2024 · 3 comments
Labels
💪 enhancement New feature or request stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed

Comments

@LeoQuote
Copy link
Contributor

Self Checks

  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report (我已阅读并同意 Language Policy).
  • Pleas do not modify this template :) and fill in all the required fields.

1. Is this request related to a challenge you're experiencing?

Previously a helm chart was developed by @BorisPolonsky at #393, but this helm chart contains certain problems:

  1. sensitive info like database password is passed by plain text and stored in configmap (which is also plain text)
  2. extensive values file making people hard to just getting started, and no readme file to guide users.

2. Describe the feature you'd like to see

I developed a brand-new helm chart -> https://github.com/douban/charts/tree/master/charts/dify

This new chart is friendly for newcomers, with a simple minimal values file less than 20 lines, you can have a dify up and running inside k8s.

For power users, you can set all your config with environment variables, using k8s native environment definition, which make it possible for you to use vault or other secret manager to predefine these sensitive data.

- name: DB_USERNAME
  value: "foo"
- name: DB_PASSWORD
  valueFrom:
    secretKeyRef:
      name: dify
      key: DB_PASSWORD

3. How will this feature improve your workflow or experience?

Summary, the new chart is simple yet powerful, the following are the advantages:

  1. making use of ingress instead of the standalone nginx pod, no extra pods just for proxying
  2. support native environment variable in k8s, making it possible to use predefined secret instead of password in plain text.
  3. simple minimal config for experiment, and detailed guide for user to move it into production.

Disadvantage:

  1. currently embedded vector database is not supported, you have to prepare one previously and set the environment
  2. to avoid possible conflict when starting up API containers, the auto migration is disabled, users must execute flask db upgrade manully after installation and upgrade.

4. Additional context or comments

No response

5. Can you help us with this feature?

  • I am interested in contributing to this feature.
@LeoQuote LeoQuote added the 💪 enhancement New feature or request label Mar 21, 2024
Copy link

dosubot bot commented Mar 21, 2024

That's great to hear that you're interested in contributing to this feature! Your new helm chart sounds like it addresses some important issues and provides valuable improvements. We encourage you to go ahead and create a pull request with your changes. Thank you for your willingness to contribute!

About Dosu

This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

If you want to continue the conversation, start your reply with @dosu-bot.

@BorisPolonsky
Copy link
Contributor

Nice

@LeoQuote
Copy link
Contributor Author

@BorisPolonsky Thanks for the support! You can try this chart or maybe submit new issues, thanks for your previous contribution!

@crazywoola crazywoola pinned this issue Mar 22, 2024
@crazywoola crazywoola changed the title Sharing a new helm chart for dify Dify helm chart Mar 22, 2024
@dosubot dosubot bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Apr 22, 2024
@langgenius langgenius locked and limited conversation to collaborators Apr 24, 2024
@crazywoola crazywoola converted this issue into discussion #3769 Apr 24, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
💪 enhancement New feature or request stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed
Projects
None yet
Development

No branches or pull requests

3 participants
@LeoQuote @BorisPolonsky and others