Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests/extras to gh actions workflows #416

Open
pchalasani opened this issue Feb 28, 2024 · 1 comment
Open

Add tests/extras to gh actions workflows #416

pchalasani opened this issue Feb 28, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@pchalasani
Copy link
Contributor

Add another run in pytest.yml that installs the relevant extra deps and runs pytest tests/extras so that we don't neglect these tests.

@pchalasani pchalasani added the enhancement New feature or request label Feb 28, 2024
@pchalasani
Copy link
Contributor Author

In future, when we have tests that depend on optional/extra deps, we should keep the tests in tests/main and skip the test when the corresponding import fails, e.g. how I just did this in test_vector_stores.py where I skip chroma test. In the main pytest.yml workflow, we install the extras using poetry install -E "chromadb,transformers" (as an example) so that the extra deps get included and the tests are comprehensive, including extra deps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant