-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug]: InboundFees are overwritten if they were not explicitly specified in lncli #8614
Comments
I think it's an existing bug with the way |
Looked in the code because I wondered why I think we need also a boolean like |
I'll jump on this. If there are any more relevant details that i might need, please share them. Thanks |
Pretty cool. Had a short look on this some days ago. But haven't really started. So let's go. |
Started working on this. PR soon (tm) https://github.com/feelancer21/lnd/tree/preserve-inbound-fees |
Awesome I am caught up with something. Looking forward to the PR |
Background
I run the current master on testnet and tested the setting of inbound fees with
lncli updatechanpolicy
. But the inbound fees are not preserved if I run the command without the command line flagsYour environment
lnd
fn/v1.0.5-129-gb1175514f
Steps to reproduce
set inbound fees with
lncli updatechanpolicy --base_fee_msat 0 --fee_rate_ppm 200 --time_lock_delta 144 --inbound_fee_rate_ppm -100 --inbound_base_fee_msat -1 --chan_point 9952586a20fecd4d99c3f400c44f10e17c674f1050f773656a42acbf7b80901c:0
check the inbound fees
Set the policy again without inbound fees
lncli updatechanpolicy --base_fee_msat 0 --fee_rate_ppm 300 --time_lock_delta 144 --chan_point 9952586a20fecd4d99c3f400c44f10e17c674f1050f773656a42acbf7b80901c:0
Check the inbound fees again
Expected behaviour
Inbound Fees have to be preserved.
The text was updated successfully, but these errors were encountered: