Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lunar 1.0 Admin Panel: Decimal places bug when creating Discount, in Minimum Cart Amount & Amount (Fixed Value) #1749

Open
ha-zeek opened this issue May 15, 2024 · 1 comment · May be fixed by #1751
Labels
1.x bug Something isn't working

Comments

@ha-zeek
Copy link

ha-zeek commented May 15, 2024

  • Lunar version: 1.0.0-alpha.17
  • Laravel Version: 10.48.10
  • PHP Version: 8.1
  • Database Driver & Version: MySQL 8

Expected Behaviour:

In Discount Resource in Admin Panel, adding 1 GBP instead 0.01 GBP to get £1.00 off or £1.00 minimum cart amount.

Actual Behaviour:

image

I'd have to put 0.01 GBP, to get £1.00.

image

Steps To Reproduce:

  1. Create a currency with 2 decimal place as such

image

  1. Create a discount in admin panel and fill in the minimum cart amount & amount off (fixed value).
@ha-zeek ha-zeek added bug Something isn't working unconfirmed labels May 15, 2024
@alecritson alecritson linked a pull request May 15, 2024 that will close this issue
@alecritson
Copy link
Collaborator

Thanks @ha-zeek Think I tracked it down and I've started a draft PR. Just need to double check tests and if anymore are needed them hopefully this will be fixed up.

@glennjacobs glennjacobs added the 1.x label May 20, 2024 — with Linear
@glennjacobs glennjacobs changed the title Lunar 1.0 Admin Panel: Decimal places bug when creating Discount, in Minimum Cart Amount & Amount (Fixed Value) Lunar 1.0 Admin Panel: Decimal places bug when creating Discount, in Minimum Cart Amount & Amount (Fixed Value) May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants