Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] required_options not updating correctly #38720

Open
2 of 5 tasks
m2-assistant bot opened this issue May 14, 2024 · 4 comments · May be fixed by #38715
Open
2 of 5 tasks

[Issue] required_options not updating correctly #38720

m2-assistant bot opened this issue May 14, 2024 · 4 comments · May be fixed by #38715
Assignees
Labels
Area: Catalog Component: DB Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: PR in progress Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@m2-assistant
Copy link

m2-assistant bot commented May 14, 2024

This issue is automatically created based on existing pull request: #38715: required_options not updating correctly


Description (*)

When a product no longer has a required option this isn't reflected in the DB / frontend.

Related Pull Requests

N/A

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

  1. Create a product, with custom options.
  2. Make one or more of the options required.
  3. Save the product.
  4. run select * from catalog_product_entity where entity_id = ENTITY_ID; , validate required_options == 1
  5. Make all the custom options not required.
  6. Save the product
  7. run select * from catalog_product_entity where entity_id = ENTITY_ID; again.
    IF BROKEN: required_options will still be 1
    IF FIXED: required_options will be 0

Questions or comments

Haven't tested this via the API only via the MAP. Have validated that when the product doesn't have any required custom options required_options isn't passed in the payload. (So it's not the UI that's broken)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label May 14, 2024
@m2-assistant m2-assistant bot linked a pull request May 14, 2024 that will close this issue
6 tasks
@m2-community-project m2-community-project bot added this to Pull Request In Progress in High Priority Backlog May 14, 2024
@engcom-Dash engcom-Dash self-assigned this May 14, 2024
Copy link
Author

m2-assistant bot commented May 14, 2024

Hi @engcom-Dash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

    1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
    1. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
    1. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

@engcom-Dash
Copy link

Hi @adamzero1

Thanks for reporting and collaboration.

Verified the issue on magento 2.4 dev instance and the issue is reproducable.

Steps to reproduce:

  1. Create a product, with custom options.
  2. Make one or more of the options required.
  3. Save the product.
  4. run select * from catalog_product_entity where entity_id = ENTITY_ID; , validate required_options == 1
  5. Make all the custom options not required.
  6. Save the product
  7. run select * from catalog_product_entity where entity_id = ENTITY_ID; again.
  8. IF BROKEN: required_options will still be 1
  9. IF FIXED: required_options will be 0

The required_opetions not updating correctly.

Please refer the attached screenshots.

Screenshot 2024-05-19 at 11 37 55 PM Screenshot 2024-05-19 at 11 38 58 PM

@engcom-Dash engcom-Dash added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Component: DB Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Area: Catalog labels May 19, 2024
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-11972 is successfully created for this GitHub issue.

Copy link
Author

m2-assistant bot commented May 19, 2024

✅ Confirmed by @engcom-Dash. Thank you for verifying the issue.
Issue Available: @engcom-Dash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Catalog Component: DB Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: PR in progress Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
High Priority Backlog
  
Pull Request In Progress
Development

Successfully merging a pull request may close this issue.

3 participants