Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StackOverflow SVG renders a black box #9

Open
nathanmyles opened this issue Aug 13, 2020 · 2 comments
Open

StackOverflow SVG renders a black box #9

nathanmyles opened this issue Aug 13, 2020 · 2 comments

Comments

@nathanmyles
Copy link

This is a great theme, thanks!

I'm noticing that the stack overflow svg seems to just render a black box, the other svgs look to be working.

@nathanmyles
Copy link
Author

#10 This fixed it for me

@jhauraw
Copy link
Member

jhauraw commented Aug 15, 2020

@nathanmyles thank you for digging Axiom.

The issue the SO icon is something I had to make a choice on. Due to the limitations of vector graphics and the way SO's icon is designed, you can't punch out the two shapes into one like a normal icon. It's a very rare occurrence, but their icon just happens to be that way. Due to this the fill-current class doesn't work well.

I don't want to hardcode a fill in the SVG itself because this opinionates the icon towards white background websites, which are common, but not universal. Also, all of the icons in Axiom have a transparent background for the widest compatibility with websites color schemes, and having one with a white fill would not be the type of solution I would like for Axiom.

So for now, I don't see a clean solution to the issue you raise. Your PR #10 does work and the easiest way for users to apply that is via an override in their own project by creating the same directory structure and adding your changed SVG to their own project. Hugo will then use the user created SVG instead of Axiom's.

User website project:

layouts
-- partials
  -- svg
    -- stackoverflow.svg

I'll leave this issue open, in case you or others have time to find another solution. I won't have time until next month to look into it further.

Thank you for your submission and comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants