Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove font padding from the game info header's second title #142

Open
mars885 opened this issue Jun 14, 2022 · 1 comment
Open

Remove font padding from the game info header's second title #142

mars885 opened this issue Jun 14, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@mars885
Copy link
Owner

mars885 commented Jun 14, 2022

In the XML world, TextView allows disabling the font padding by specifying includeFontPadding="false". This was used by the second title of the game info header to remove any extra space between the first title & second one.

However, as of 1.1.1 version of the Jetpack Compose, it's not possible to do that. As of the 1.2.0-beta01, the support for that has been added. As soon as the project gets updated to use 1.2.0 version of the Jetpack Compose, consider removing the font padding, just like it was before the migration to Compose.

@mars885 mars885 added the enhancement New feature or request label Jun 14, 2022
@mars885 mars885 self-assigned this Jun 14, 2022
@mars885
Copy link
Owner Author

mars885 commented Aug 1, 2022

Since Jetpack Compose 1.2 has been released recently, it provides an experimental API to try out setting includeFontPadding property.

However, since it is planned to make includeFontPadding property to be false by default in an upcoming release, it makes no sense to put the experimental code just to remove it a couple of releases later.

Therefore, as soon as a release of Compose comes out that sets includeFontPadding to false by default, double-test for visual changes and call it a day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant