Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Opt out not compatible with some older browsers #22215

Open
4 tasks done
tsteur opened this issue May 14, 2024 · 2 comments
Open
4 tasks done

[Bug] Opt out not compatible with some older browsers #22215

tsteur opened this issue May 14, 2024 · 2 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.

Comments

@tsteur
Copy link
Member

tsteur commented May 14, 2024

What happened?

We offer the ability to embed a Tracking Opt Out see https://matomo.org/faq/general/faq_20000/

seeing https://github.com/matomo-org/matomo/pull/22210/files there is a const in the opt out code which makes me think the opt out is not functional on some older browsers such as IE 10. I didn't specifically test it but would assume this is the case.

In terms of tracking code we support also older browsers see text at the bottom in https://matomo.org/faq/new-to-piwik/faq_20541/

What should happen?

Make Opt out work with older browsers.

Or maybe the opt out iframe still works there and docs can be adjusted to make this clear?

How can this be reproduced?

Embed opt out in IE 10

Matomo version

5.0.0

PHP version

No response

Server operating system

No response

What browsers are you seeing the problem on?

Other

Computer operating system

No response

Relevant log output

No response

Validations

@tsteur tsteur added Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. To Triage An issue awaiting triage by a Matomo core team member labels May 14, 2024
@sgiehl sgiehl added Bug For errors / faults / flaws / inconsistencies etc. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. To Triage An issue awaiting triage by a Matomo core team member labels May 14, 2024
@sgiehl
Copy link
Member

sgiehl commented May 14, 2024

I've created a PR to fix the problem with const only, as that clearly breaks on older browsers. But we still need to do some testing on older browsers to see if everything else works correctly for the opt out.
As part of this issue we should also consider adding tests for some older browsers, as we are currently only running test with latest chrome and will not see such problems early enough.

@sgiehl sgiehl added this to the For Prioritization milestone May 14, 2024
@michalkleiner
Copy link
Contributor

As part of this work, it would great to define what older browsers we want to support for the tracker and/or what does 'on best effort basis' mean.
With "we try to support as much as we can" there's no boundary and someone can always say "this doesn't work for me" or "we can't use that".
Based on https://caniuse.com/const const is available to 97% percent of users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

3 participants