Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test CI failing when enabling/disabling some features #4629

Open
2 tasks
curquiza opened this issue May 13, 2024 · 2 comments · Fixed by #4684 · May be fixed by #4685
Open
2 tasks

Test CI failing when enabling/disabling some features #4629

curquiza opened this issue May 13, 2024 · 2 comments · Fixed by #4684 · May be fixed by #4685
Labels
bug Something isn't working as expected good first issue Good for newcomers maintenance Issue about maintenance (CI, tests, refacto...)
Milestone
v1.9.0

Comments

@curquiza
Copy link
Member

curquiza commented May 13, 2024 •
edited

Scheduled CI is failing on main

https://github.com/meilisearch/meilisearch/actions/runs/9057514821

Capture d’écran 2024-05-13 à 10 05 35 Capture d’écran 2024-05-13 à 10 06 43
@curquiza curquiza added bug Something isn't working as expected good first issue Good for newcomers maintenance Issue about maintenance (CI, tests, refacto...) labels May 13, 2024
@curquiza curquiza added this to the v1.9.0 milestone May 13, 2024
@ManyTheFish ManyTheFish mentioned this issue May 21, 2024
Closed
@ManyTheFish
Copy link
Member

I've created an issue on Charabia to fix this:
meilisearch/charabia#290

@ManyTheFish ManyTheFish mentioned this issue Jun 6, 2024
Merged
meili-bors bot added a commit that referenced this issue Jun 6, 2024
@meili-bors @ManyTheFish
Merge #4684
cb765ad 
4684: Update Charabia v0.8.11 r=irevoire a=ManyTheFish

# Update Charabia v0.8.11

### Adds a new normalizer to normalize œ to oe and æ to ae
Now search words containing `œ` or `æ` will be retrieved using `oe` or `ae`, like `Daemon` <=> `Dæmon`

### Fix: make `chinese-normalization-pinyin` feature flag compile
Fixes #4629



Co-authored-by: ManyTheFish <many@meilisearch.com>
@ManyTheFish ManyTheFish linked a pull request Jun 6, 2024 that will close this issue
Update Charabia v0.8.11 #4684
Merged
@curquiza
Copy link
Member Author

curquiza commented Jun 6, 2024 •
edited

@ManyTheFish it's stil failing 😢

https://github.com/meilisearch/meilisearch/actions/runs/9399941501 -> I ran the tests on the release-v1.9.0 branch after the merge of #4684

@ManyTheFish ManyTheFish linked a pull request Jun 6, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working as expected good first issue Good for newcomers maintenance Issue about maintenance (CI, tests, refacto...)
Projects
None yet
Milestone
v1.9.0
Development

Successfully merging a pull request may close this issue.

Update Charabia v0.8.11 meilisearch/meilisearch
Fix ci tests meilisearch/meilisearch
2 participants
@ManyTheFish @curquiza