Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Iterator inconsistency #380

Open
antejavor opened this issue Oct 9, 2023 · 0 comments
Open

[BUG] Iterator inconsistency #380

antejavor opened this issue Oct 9, 2023 · 0 comments
Assignees
Labels
community community Effort - Medium Effort - Medium Frequency - Monthly Frequency - Monthly Priority - Later Priority - Later Reach - VeryFew Reach - VeryFew Severity - S3 Severity - S3

Comments

@antejavor
Copy link

antejavor commented Oct 9, 2023

TODO: Check into the more details why is this happening, something with iterator copy.

Describe the bug

    auto nodes = g.Nodes();

    auto it = nodes.begin();
    while (it != nodes.end()) {
        mgp::Node node = *it;
      // Fail in this case (copy operation) 
      // it++; 16:47:17.821][Error]Unexpected error during mg API call: std::visit: variant is valueless
     // works 
     ++it;
}

Expected behavior
I think this should be consistent in both cases when working with iterators or properly documented.

@antejavor antejavor assigned gitbuda and antejavor and unassigned gitbuda Oct 9, 2023
@katarinasupe katarinasupe added Importance - I3 Importance - I3 Severity - S3 Severity - S3 Effort - Unknown Effort - Unknown community community labels Dec 27, 2023
@imilinovic imilinovic added Effort - Medium Effort - Medium and removed Effort - Unknown Effort - Unknown labels Feb 22, 2024
@hal-eisen-MG hal-eisen-MG added the Priority - Later Priority - Later label Feb 22, 2024
@katarinasupe katarinasupe added Frequency - Monthly Frequency - Monthly Reach - VeryFew Reach - VeryFew and removed Importance - I3 Importance - I3 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community community Effort - Medium Effort - Medium Frequency - Monthly Frequency - Monthly Priority - Later Priority - Later Reach - VeryFew Reach - VeryFew Severity - S3 Severity - S3
Projects
Development

No branches or pull requests

5 participants