Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config updater outputs misleading warnings #396

Open
devon-research opened this issue Mar 14, 2024 · 1 comment
Open

Config updater outputs misleading warnings #396

devon-research opened this issue Mar 14, 2024 · 1 comment
Assignees
Labels

Comments

@devon-research
Copy link

If I pass an FSDP config flag to finetuning.py, as in e.g.

torchrun \
    --nproc_per_node 4 \
    llama-recipes/examples/finetuning.py \
        --enable_fsdp \
        --model_name meta-llama/Llama-2-7b-hf \
        --dist_checkpoint_root_folder model_checkpoints \
        --dist_checkpoint_folder fine-tuned \
        --pure_bf16 \
        --use_fast_kernels

then in the output I get

Warning: unknown parameter pure_bf16

It looks like the code to update the config has a bug where if a config parameter appears in the FSDP config but not in the training config, it will erroneously output a warning like this.

@HamidShojanazeri
Copy link
Contributor

@devon-research can you please install from src, it works on my end. BTW we did some refactor recently would be great to pull the latest first. Now lama-recipes/examples/finetuning.py is changed to lama-recipes/recipes/finetuning/finetuning.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants