Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo or misnaming in automl/timeseries/ts_model.py #1279

Open
enkiluv opened this issue Feb 19, 2024 · 1 comment · May be fixed by #1312
Open

Typo or misnaming in automl/timeseries/ts_model.py #1279

enkiluv opened this issue Feb 19, 2024 · 1 comment · May be fixed by #1312

Comments

@enkiluv
Copy link

enkiluv commented Feb 19, 2024

In version 2.x.x: (especially 2.1.1)

Lines 613 and 616:
if (
self.params["seasonal"] == "mul" and (train_df.y == 0).sum() > 0
): # cannot have multiplicative seasonality in this case
self.params["seasonal"] = "add"
if self.params["trend"] == "mul" and (train_df.y == 0).sum() > 0:
self.params["trend"] = "add"

train_df.y == 0 should be train_df[target_col] == 0 . Isn't it? (two places)

@Programmer-RD-AI
Copy link

Hi,
I have created a PR #1312 feel free to check it :)
Best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants