Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Regression]: "Playwright Test for VSCode" v1.1.1 extension adds config to .vscode\settings.json file #30780

Closed
kosteklvp opened this issue May 14, 2024 · 2 comments · Fixed by microsoft/playwright-vscode#476
Assignees
Labels

Comments

@kosteklvp
Copy link

kosteklvp commented May 14, 2024

Last Good Version

1.0.22

First Bad Version

1.1.1

Steps to reproduce

  1. Open "TESTING: PLAYWRIGHT" view.
  2. Select project in "PROJECTS" section.
    obraz

Expected behavior

Nothing was added to .vscode/settings.json file, when changing default project.

Actual behavior

This section is added to .vscode/settings.json file.
obraz

I don't think this is a good place to save this information, because this file can be tracked by VCS.

Additional context

No response

Environment

System:
    OS: Windows 11 10.0.22631
  Binaries:
    Node: 20.12.2 - C:\Program Files\nodejs\node.EXE
    npm: 10.5.0 - C:\Program Files\nodejs\npm.CMD
  IDEs:
    VSCode: 1.88.1
  Languages:
    Bash: 5.1.16
  npmPackages:
    @playwright/test: ^1.40.0 => 1.43.1
@mxschmitt
Copy link
Member

Sounds like we should switch to workspaceState instead: https://code.visualstudio.com/api/extension-capabilities/common-capabilities#data-storage

@mxschmitt
Copy link
Member

@kosteklvp this should be fixed in v1.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants