Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot open a closed PR #6005

Closed
bpasero opened this issue May 16, 2024 · 8 comments
Closed

Cannot open a closed PR #6005

bpasero opened this issue May 16, 2024 · 8 comments
Assignees

Comments

@bpasero
Copy link
Member

bpasero commented May 16, 2024

This may be a design limitation or cannot be supported, but it would be great if I could open a closed PR and still interact with it. I can do that on Github.com and still add comments and do code review.

Today when you open a closed PR by pressing . on github VSCode opens but not the PR.

@alexr00
Copy link
Member

alexr00 commented May 21, 2024

Duplicate of #4613. You can restore the branch to work around this.

@alexr00 alexr00 closed this as completed May 21, 2024
@bpasero
Copy link
Member Author

bpasero commented May 21, 2024

In this case I am not sure if the branch was deleted and I am also not sure if I can restore a branch that I did not create 🤔

@alexr00
Copy link
Member

alexr00 commented May 21, 2024

Hmm, if the branch is not deleted then maybe you have GHPR configured to not show the PR for closed PRs. Do you have "githubPullRequests.useReviewMode": "auto"? That should get you the behavior you want.

@bpasero
Copy link
Member Author

bpasero commented May 21, 2024

This is mainly pressing "." on a github.dev

@alexr00
Copy link
Member

alexr00 commented May 21, 2024

The default value of "githubPullRequests.useReviewMode" is auto, but if you have setting sync turned on then you may have lost it.

@bpasero
Copy link
Member Author

bpasero commented May 21, 2024

Interesting, I had this configured, removed it now:

"githubPullRequests.useReviewMode": {
    "merged": false,
    "closed": false
}

@bpasero
Copy link
Member Author

bpasero commented May 21, 2024

Wow that was really it, thanks!

@alexr00
Copy link
Member

alexr00 commented May 23, 2024

auto came later to resolve exactly this issue. Glad it worked!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants