Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote-SSH Bug]: remote.SSH.connectTimeout not respected using exec server #9894

Closed
3 tasks done
jeanp413 opened this issue May 17, 2024 · 2 comments
Closed
3 tasks done
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug ssh Issue in vscode-remote SSH
Milestone

Comments

@jeanp413
Copy link

Is there an existing issue for this bug?

  • I have searched the existing issues

Required Troubleshooting Steps

  • I have followed these troubleshooting steps
  • I have tried both values of the remote.SSH.useLocalServer setting

Connect Locally

It connects successfully

->

remote.SSH.connectTimeout is not respected in the ssh command used by exec server, I see it uses -o ConnectTimeout=15 always

Expected Behavior

remote.SSH.connectTimeout is respected in the ssh command used by exec server

Steps To Reproduce

No response

Remote-SSH Log

Remote-SSH Log

[PASTE LOG HERE]

Anything else?

No response

@jeanp413 jeanp413 added the ssh Issue in vscode-remote SSH label May 17, 2024
@roblourens roblourens assigned connor4312 and unassigned roblourens May 17, 2024
@connor4312
Copy link
Member

connor4312 commented May 20, 2024

I'm not able to repro this, and looking at the code we put the setting value directly into the command the only place we create a ConnectTimeout argument. Can you please share additional logs/repro steps? Also, please verify that you do not have a ConnectTimeout option configured in the SSH host config, as that will be preferred.

@connor4312 connor4312 added the info-needed Issue requires more information from poster label May 20, 2024
@jeanp413
Copy link
Author

@connor4312 I tested again and seems it only doesn't work for "remote.SSH.connectTimeout": 0, I'm trying to disable it as setting a value greater than 0 causes ssh to resolve the host which takes a considerable time in my case.

Also, please verify that you do not have a ConnectTimeout option configured in the SSH host config, as that will be preferred.

That's not what I see, ConnectTimeout from ssh config file is always ignored, I created an issue a long time ago for that #8519

@connor4312 connor4312 added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels May 30, 2024
@connor4312 connor4312 added this to the June 2024 milestone May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug ssh Issue in vscode-remote SSH
Projects
None yet
Development

No branches or pull requests

3 participants