Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip only displaying for Show Settings Watermark Control+, #212355

Closed
manoellvitor opened this issue May 9, 2024 · 3 comments · Fixed by #212777
Closed

Tooltip only displaying for Show Settings Watermark Control+, #212355

manoellvitor opened this issue May 9, 2024 · 3 comments · Fixed by #212777
Assignees
@bhavyaus @benibenj
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member insiders-released Patch has been released in VS Code Insiders regression Something that used to work is now broken verified Verification succeeded
Milestone
May 2024

Comments

@manoellvitor
Copy link

Version of VS Code: 1.89.0
image
Your operating system: Windows 11
List of extensions that you have installed: Happens with none installed.
Reproducible steps:
1 - Open VsCode.
2 - Hover over the Show Settings Ctrl + , Watermark
3 - Hover over Find in Files Ctrl + Shift + F
What you expected to see, versus what you actually saw:
When hover on Ctrl + ,
image

When hover on Ctrl + Shift + F and any other
image

vscode/src/vs/workbench/browser/parts/editor/editorGroupWatermark.ts

Line 39 in 9eff384

const showSettings: WatermarkEntry = { text: localize('watermark.showSettings', "Show Settings"), id: 'workbench.action.openSettings' };

@rzhao271 rzhao271 assigned bhavyaus and unassigned rzhao271 May 9, 2024
@bhavyaus bhavyaus added bug Issue identified by VS Code Team member as probable bug and removed triage-needed labels May 9, 2024
@bhavyaus bhavyaus added this to the May 2024 milestone May 9, 2024
eisemsi2 added a commit to eisemsi2/vscode that referenced this issue May 10, 2024
@eisemsi2
fix for issue microsoft#212355
065c95c
@eisemsi2 eisemsi2 mentioned this issue May 10, 2024
Closed
@bpasero bpasero added the regression Something that used to work is now broken label May 10, 2024
@bpasero bpasero added the confirmed Issue has been confirmed by VS Code Team member label May 10, 2024
@bpasero
Copy link
Member

bpasero commented May 10, 2024

This is a regression from cff275a#diff-8113c62998d6b21d8fb9d4d4c7f811ba447c04d5c6e5dae7a48f4edbd52b2d39

@eisemsi2
Copy link

@bpasero Does the fix #212406 cause some other bug?

@bpasero
Copy link
Member

bpasero commented May 10, 2024

I think we need to properly keep track of disposables.

benibenj added a commit that referenced this issue May 15, 2024
@benibenj
fixes #212355
9ed39e1
@benibenj benibenj mentioned this issue May 15, 2024
Merged
benibenj added a commit that referenced this issue May 15, 2024
@benibenj
Fix hovers on empty group watermarks (#212777)
6ade685 
fixes #212355
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 15, 2024
@andreamah andreamah added the verified Verification succeeded label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bhavyaus bhavyaus

@benibenj benibenj

Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member insiders-released Patch has been released in VS Code Insiders regression Something that used to work is now broken verified Verification succeeded
Projects
None yet
Milestone
May 2024
Development

Successfully merging a pull request may close this issue.

Fix hovers on empty group watermarks microsoft/vscode
fix for issue #212355 eisemsi2/vscode
8 participants
@bpasero @rzhao271 @manoellvitor @bhavyaus @andreamah @benibenj @eisemsi2 @VSCodeTriageBot