Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typing enter doesn't execute command when terminal suggest modal visible #212450

Open
cpendery opened this issue May 10, 2024 · 0 comments · May be fixed by #212470
Open

Typing enter doesn't execute command when terminal suggest modal visible #212450

cpendery opened this issue May 10, 2024 · 0 comments · May be fixed by #212470
Assignees
@Tyriar

Comments

@cpendery
Copy link
Member

Terminal suggest does not execute on typing enter, instead it only dismisses the suggest modal

Does this issue occur when all extensions are disabled?: Yes

Version: 1.90.0-insider (user setup)
Commit: 6046891
Date: 2024-05-08T05:51:16.876Z
Electron: 28.2.8
ElectronBuildId: 27744544
Chromium: 120.0.6099.291
Node.js: 18.18.2
V8: 12.0.267.19-electron.0
OS: Windows_NT x64 10.0.22631

Steps to Reproduce:

  1. Open powershell with "terminal.integrated.shellIntegration.suggestEnabled": true
  2. Type ls
  3. Hit enter and see the command not executed, but the terminal suggest modal hides
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove enter as a keybinding for accepting a terminal suggestion cpendery/vscode
2 participants
@Tyriar @cpendery