Terminal: inline chat widget is not consistently hidden

[bpasero]

For the voice integration to chat, I need to rely on an event when inline chat is hidden. I found that there is a hide method:

vscode/src/vs/workbench/contrib/terminalContrib/chat/browser/terminalChatWidget.ts

Line 161 in 743d036

hide(): void {

However, I see that it is not being called in these cases:

• open a terminal in panel and start inline chat, start voice chat
• open another panel so that terminal is hidden
• 🐛 voice chat does not stop

A similar issue when terminals are in the editor and you open another editor.

Would it be possible for terminal to ensure hide is called in these cases? I have #212653 for then stopping the voice chat session, but it needs to be called.

[bpasero]

Thanks, but it does not work for me, when this._focusTracker.onDidBlur is called, this._instance.isVisible is still true. I tried this:

• open a terminal, open inline chat
• start recording voice (notice on macOS how a new yellow icon appears in the top right indicating audio recording)
• switch to another panel
• recording does not stop

[meganrogge]

In the editor, if there's been no response, the inline chat widget hides on blur. If there's been a response, it doesn't hide unless I press escape.

I'll do the same for the terminal.

[bpasero]

If I have a chat open in a terminal (panel) and click on another panel, the chat is still not getting hidden, so voice actions continue to work even though not visible.

[meganrogge]

That also happens in the chat in the editor, so I was following suit. When I hide the editor by clicking a different one, if there's been a response, the voice actions continue to work even though they're not visible.

chat.mov

[bpasero]

Yeah fair, as long as the voice stuff can still be turned off from the opened widget.