Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Q: Why rotary embedding applied only to queries and keys? #147

Open
pmgautam opened this issue Apr 20, 2024 · 0 comments
Open

Q: Why rotary embedding applied only to queries and keys? #147

pmgautam opened this issue Apr 20, 2024 · 0 comments

Comments

@pmgautam
Copy link

In the codebase, rotary embeddings are applied only to queries and keys but not to values. Can someone point out to reasons/papers behind this design? Thank you in advance!!!

image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pmgautam