refactor: assign less than min threshold students to previous center #51
+53
−43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new implementation fixes the #13 of allocating small amount of students to a new center.
Details
calc_per_center
MIN_STUDENT_IN_CENTER
), they are assigned to the first center of that specific school.MIN_STUDENT_IN_CENTER
), they are assigned to a new centerThe PR also abstract the center allocation logic to a new function
allocate_to_centers
.I saw that there is a WIP PR related to the unit test. I can also add the test for
allocate_to_centers
function once the that PR is merged to make sure that the allocation is working as expected.Resolves #13