Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] #83 Improvement of Streamlit Interface for School/Center Searching #88

Conversation

nirmala-sharma
Copy link
Contributor

@nirmala-sharma nirmala-sharma commented Apr 30, 2024

Fixes #83

Task Done:

  • Instead of four radio buttons options scode | school | cscode | center, could we just keep two school | center and show the code along side the school/center name.

  • Also make it searchable by both name and code.

  • Use horizontal layout for radio options for efficient use of screen space: For this i have added a custom css

  • Do not use thousand separator comma (27,056) in scode / cscode

  • Show Only Unique School,Center,scode,cscode values in filter dropdown and hide index of the filtered table

Copy link
Contributor

@dhirajraut1 dhirajraut1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. 🚀
It's good to show only the unique values.

app.py Outdated Show resolved Hide resolved
app.py Outdated Show resolved Hide resolved
@sapradhan
Copy link
Collaborator

sapradhan commented May 4, 2024

Thank you for this.

These dont seem to work -

  • Use horizontal layout for radio options for efficient use of screen space: For this i have added a custom css. This does not work in firefox
  • Do not use thousand separator comma (27,056) in scode / cscode

image

@nirmala-sharma
Copy link
Contributor Author

@sapradhan Completed reviewed changes Do not use thousand separator comma (27,056) in scode / cscode

But this issue Use horizontal layout for radio options for efficient use of screen space: For this i have added a custom css. This does not work in firefox is not replicated in either browsers in my machine . I have tested in chrome, brave,edge and firefox .

Below is the image of firefox:
image

@sumanashrestha
Copy link
Collaborator

thank you, try to fix other issues reported in #83

@sumanashrestha sumanashrestha merged commit 3d0fb81 into moest-np:main May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

School / Center searchable by name or code in single dropdown
4 participants