Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix socketed item description #105

Open
mofr opened this issue Feb 16, 2020 · 0 comments
Open

Fix socketed item description #105

mofr opened this issue Feb 16, 2020 · 0 comments
Labels

Comments

@mofr
Copy link
Owner

mofr commented Feb 16, 2020

That one (Item.DescribeProperty func 14) is incorrect, it’s
sb.Append(prop.param); and not value

Also the block.stat == null will not trigger because
block.stat = item_numsockets
But the prop item_numsockets do not have a description function so it will reach line 593 but has nothing to display.
Example
[id] => sock
[is_active] => 1
[block1_set] =>
[block1_val] =>
[block1_func] => 14
[block1_stat] => item_numsockets
[notes] => none
[affixId] => Jeweler's
[param] => 4
[min] =>
[max] =>
[value] => 0

That one is a bit tricky, it can use the param on some affixes like Jeweler that add a fix 4 sockets, while it can use the value like on Mechanist affix with a min/max, so it require a double check, if param is set use that, otherwise use value.

cc @giviz

@mofr mofr added the bug label Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant