Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to specify the fragment manager for showing dialogs #221

Open
Sdghasemi opened this issue Oct 12, 2019 · 2 comments
Open

Option to specify the fragment manager for showing dialogs #221

Sdghasemi opened this issue Oct 12, 2019 · 2 comments

Comments

@Sdghasemi
Copy link

Thanks for the marvelous library, such a great help for managing loads of fragments.
It'd be great if there was be an option for passing a fragment manager as the dialog parent fm to attach to. A simple and easy use-case example is when you're having multiple fragments inside a parent fragment (referring as currentFrag) (like a view pager kind of situation) and you need to set the interaction listener for the dialog through getParentFragment() method. Currently it's assigned to the so called currentFrag which has to pass listener method calls to its child fragment which is not a neat solution.
Thanks in advance.

@ncapdevi
Copy link
Owner

@Sdghasemi This seems reasonable to me. Would need to actually code it up to make sure there aren't any issues that it would expose, but I see the use case. Hopefully it is something that can be added in the future.

@mirjalal
Copy link

Thank you for this lib! Helped me a lot. However, I also faced with that issue. @ncapdevi is there any progress about this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants