Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory Leak when the user closes the dialog shown via FragNavController.showDialogFragment #246

Open
artsmvch opened this issue Jan 29, 2022 · 0 comments

Comments

@artsmvch
Copy link

I was profiling my app and noticed that my closed dialog is not being garbage collected. Then I checked the references and found out that the FragNavController was holding a ref, namely the mCurrentDialogFrag field.
I suggest you make a weak reference to the current dialog frag instead of a strong reference for such cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant