Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing icon when macOS from "cargo install"ed binary #2431

Open
technicalpickles opened this issue Mar 19, 2024 · 1 comment
Open

missing icon when macOS from "cargo install"ed binary #2431

technicalpickles opened this issue Mar 19, 2024 · 1 comment
Labels
bug Something isn't working macos Specific to macOS and not investigable on other platforms

Comments

@technicalpickles
Copy link

technicalpickles commented Mar 19, 2024

Describe the bug

I've been using neovide via the homebrew HEAD recipe for awhile now. I've noticed when it's running, neovide doesn't have its icon, just whatever is the default icon for something compiled:

CleanShot 2024-03-19 at 08 20 44

I've tried the non-HEAD formula, and that seems to happen too.

Also: I'll acknowledge this could be a homebrew specific thing, but figured I'd start here.

To Reproduce
Steps to reproduce the behavior:

  1. git clone https://github.com/neovide/neovide.git
  2. cd neovide
  3. cargo install --path .
  4. .cargo/bin/neovide
  5. use ⌘ - tab to pull up the command switcher
  6. see a default icon

Expected behavior

It should have the N logo, ie the one on the GitHub org

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: macOS 14.4
  • Neovide Version: 0.12.2 (but also HEAD)
  • Neovim Version 0.9.5

Please run neovide --log and paste the contents of the .log file created in the current directory here:

neovide_rCURRENT.log
neovide_r2024-03-19_08-24-49.log

Additional context
Add any other context about the problem here.

@technicalpickles technicalpickles added the bug Something isn't working label Mar 19, 2024
@technicalpickles
Copy link
Author

technicalpickles commented Apr 10, 2024

I think I found the reason for this... I had previously cloned and locally installed neovide 🤦🏻

❯ which neovide
/Users/josh.nichols/.cargo/bin/neovide

I was able to fix it with:

❯ cd ~/workspace/neovide/
❯ cargo uninstall
    Removing /Users/josh.nichols/.cargo/bin/neovide
❯ which neovide                                                                                                                                                                             
/opt/homebrew/bin/neovide

Afterwards, when running neovide:

CleanShot 2024-04-10 at 10 45 48

Given that, I think this can be rescoped as "missing icon when macOS from cargo install'd binary". I'll update to reflect that.

@technicalpickles technicalpickles changed the title macOS application doesn't consistently have correct icon missing icon when macOS from "cargo install"ed binary Apr 10, 2024
@fredizzimo fredizzimo added the macos Specific to macOS and not investigable on other platforms label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working macos Specific to macOS and not investigable on other platforms
Projects
None yet
Development

No branches or pull requests

2 participants