Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easier the modification of ns-train colmap options such as --downscale-factor #3144

Open
remmel opened this issue May 14, 2024 · 1 comment

Comments

@remmel
Copy link

remmel commented May 14, 2024

Finding how to disable/change downscale using CLI is not easy, while this is as easy as doing:
ns-train splatfacto --data mydatadir colmap --downscale-factor 1

The doc indicates the existance of such a parameter

I was expecting to find its presence in ns-train splatfacto --help but this is in ns-train splatfacto colmap --help.
The problem is the same for all subcommand options.

Somes ideas:

  1. add more information in optional subcommands in ns-train splatfacto --help such as: ns-train splatfacto [subcommand] --help to get pipeline.datamanager.dataparser options
  2. add in some place in the documentation
  3. move the subcommand help in the main help
  4. move the options to --pipeline.datamanager.dataparser.* eg :--pipeline.datamanager.dataparser.downscale-factor
  5. Update that message Auto image downscale factor of 4 nerfstudio_dataparser.py:484

At least that information is now here in that github issue and I'm happy with that!

@jb-ye
Copy link
Collaborator

jb-ye commented May 14, 2024

Not all data parser support downscale-factor option. Maybe we should proceed with your idea 5, so people know how to disable auto-downscale behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants